Skip to content

util: extract uncurryThis function for reuse - #23081

Closed
ZYSzys wants to merge 2 commits into
nodejs:masterfrom
zys-contrib:extract-util
Closed

util: extract uncurryThis function for reuse#23081
ZYSzys wants to merge 2 commits into
nodejs:masterfrom
zys-contrib:extract-util

Conversation

@ZYSzys

@ZYSzysZYSzys commented Sep 25, 2018

Copy link
Copy Markdown
Member

Extracts uncurryThis function which is done in identical ways in a few places in lib/internal/util dir.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Sep 25, 2018
jasnell
jasnell reviewed Sep 25, 2018
View reviewed changes
Comment threadlib/internal/util/comparisons.js Outdated
BridgeAR
BridgeAR approved these changes Sep 25, 2018
View reviewed changes
Comment threadlib/internal/util/comparisons.js Outdated
Fishrock123
Fishrock123 previously requested changes Sep 26, 2018
View reviewed changes
Comment threadtest/parallel/test-bootstrap-modules.js Outdated
lundibundi
lundibundi approved these changes Sep 26, 2018
View reviewed changes

@lundibundilundibundi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though I'm +1 for @Fishrock123 suggestion of moving this to util.js.

@ZYSzys

ZYSzys commented Sep 26, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Now I'm torn between keeping it in lib/internal/util/functional.jsor moving to lib/internal/util.js.

Hey guys, which one should I choose ? 😬

@refack

refack commented Sep 27, 2018

Copy link
Copy Markdown
Contributor

I'm not sure internal/util.js is the best place, it will create something that looks like circular dependency, files in internal/util/ depending on a file in the parent directory. (e.g. internal/util/comparisons.js -> internal/util.js)

I'm very pro deduplicating code, so to me internal/util/types.js seems like the least worst place to put this in... But let's hear from others.

@thefourtheye

thefourtheye commented Oct 6, 2018

Copy link
Copy Markdown
Contributor

We already use functions from internal/util.js in internal/util/inspect.js. So one more small function wouldn't hurt, I guess.

@refack

refack commented Oct 6, 2018

Copy link
Copy Markdown
Contributor

We already use functions from internal/util.js in internal/util/inspect.js. So one more small function wouldn't hurt, I guess.

Sounds like a good compromise. Maybe add a TODO comment that we should re-evaluate this dependency in the future?

@lundibundi

lundibundi commented Oct 8, 2018

Copy link
Copy Markdown
Member

It looks like we came to an agreement, @ZYSzys could you move the function to internal/util.js and rebase on master so this could proceed?
Also, a TODO comment proposed by @refack sounds like a good idea.

@ZYSzys

ZYSzys commented Oct 9, 2018

Copy link
Copy Markdown
MemberAuthor

It was changed now.
But I'm a little confused about the linter error.
screen shot 2018-10-09 at 10 16 38 am

How should I fixed it ?

@lundibundi

lundibundi commented Oct 9, 2018•
edited
Loading

Copy link
Copy Markdown
Member

@ZYSzys don't worry, that's a known bug, it'll be fixed soon.

CI: https://ci.nodejs.org/job/node-test-pull-request/17701/

@ZYSzys

ZYSzys commented Oct 24, 2018

Copy link
Copy Markdown
MemberAuthor

@Fishrock123@lundibundi PTAL

@refackrefack mentioned this pull request Nov 6, 2018
Closed
@ZYSzys

ZYSzys commented Dec 20, 2018

Copy link
Copy Markdown
MemberAuthor

ping @Fishrock123

Sorry for bothering you. It has almost been three months, and I've moved the uncurryThis function into lib/internal/util.js for reusable, can you please take a look at this PR again ?

@lundibundi

lundibundi commented Dec 20, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19690/

@ZYSzysZYSzys changed the title lib: extract uncurryThis functionutil: extract uncurryThis function for reuseFeb 10, 2019
@ZYSzys

ZYSzys commented Mar 19, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/21656/ ✅

@ZYSzysZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 20, 2019
@BridgeAR

BridgeAR commented Mar 21, 2019

Copy link
Copy Markdown
Member

Landed in 20fab5f, 5f032a7 🎉

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 21, 2019
@ZYSzys@BridgeAR
util: require isNativeError from internalBinding
20fab5f
PR-URL: nodejs#23081
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 21, 2019
@ZYSzys@BridgeAR
util: extract uncurryThis function for reuse
5f032a7
PR-URL: nodejs#23081
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ZYSzys
ZYSzys deleted the extract-util branch March 22, 2019 01:08
targos pushed a commit that referenced this pull request Mar 28, 2019
@ZYSzys@targos
util: require isNativeError from internalBinding
a9914f3
PR-URL: #23081
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Mar 28, 2019
@ZYSzys@targos
util: extract uncurryThis function for reuse
bc5d89d
PR-URL: #23081
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Mar 30, 2019
@ZYSzys@targos
util: require isNativeError from internalBinding
169f3f7
PR-URL: #23081
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Mar 30, 2019
@ZYSzys@targos
util: extract uncurryThis function for reuse
21486e5
PR-URL: #23081
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggsBethGriggs mentioned this pull request Apr 9, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell left review comments
@addaleaxaddaleaxaddaleax approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+7 more reviewers
@refackrefackrefack approved these changes
@Fishrock123Fishrock123Fishrock123 left review comments
@devsnekdevsnekdevsnek left review comments
@jdaltonjdaltonjdalton approved these changes
@thefourtheyethefourtheyethefourtheye approved these changes
@lundibundilundibundilundibundi approved these changes
@starkwangstarkwangstarkwang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@ZYSzys@refack@thefourtheye@lundibundi@BridgeAR@jdalton@jasnell@addaleax@Fishrock123@joyeecheung@devsnek@starkwang@nodejs-github-bot