Uh oh!
There was an error while loading. Please reload this page.
crypto: make DEFAULT_ENCODING non-enumerable - #23227
Closed
guybedford wants to merge 1 commit into
Closed
Conversation
richardlau
commented
Oct 2, 2018
Member
Duplicate of #23222. |
guybedford
commented
Oct 2, 2018
ContributorAuthor
Thanks, missed that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#23203.
Deprecated exports now need to always be non-enumerable - this pattern was established when we implemented named exports for Node core modules from ES Modules. Otherwise
import 'crypto'will always give a deprecation warning for modules.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes