Uh oh!
There was an error while loading. Please reload this page.
[v8.x backport] build: update arm64 minimum supported platform - #23275
Closed
tomleah wants to merge 1 commit into
Closed
[v8.x backport] build: update arm64 minimum supported platform#23275tomleah wants to merge 1 commit into
tomleah wants to merge 1 commit into
Conversation
This is already true in practice. PR-URL: #19164Fixes: nodejs/build#1164 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs
commented
Oct 5, 2018
Member
ping @nodejs/build (I don't think editing the description pings) |
Member
Landed in 104fbc6 |
BethGriggs pushed a commit
that referenced
this pull request
Oct 30, 2018
This is already true in practice. Backport-PR-URL: #23275 PR-URL: #19164Fixes: nodejs/build#1164 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saw that #19164 needed a backport, PTAL
cc: @gibfahn @nodejs/build
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes