Uh oh!
There was an error while loading. Please reload this page.
src,lib: make process.binding('config') internal - #23400
Closed
shisama wants to merge 1 commit into
Closed
Conversation
shisamaforce-pushed
the
config-binding
branch
3 times, most recently
from
October 15, 2018 00:47
5a2a9d6 to
1f0b70dCompare33 tasks
shisamaforce-pushed
the
config-binding
branch
4 times, most recently
from
October 18, 2018 09:20
a419245 to
58c315cCompareshisamaforce-pushed
the
config-binding
branch
18 times, most recently
from
October 25, 2018 14:22
e33577b to
2923d07Comparecjihrig
approved these changes
Nov 30, 2018
gireeshpunathil
commented
Nov 30, 2018
Member
Resume Build CI: https://ci.nodejs.org/job/node-test-commit/23812/ |
shisama
commented
Nov 30, 2018
ContributorAuthor
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19081/ |
gireeshpunathil
commented
Nov 30, 2018
Member
@shisama - what a coincidence!!! looks like we fired two CIs almost at the same time. |
trivikr
approved these changes
Dec 3, 2018
shisama
commented
Dec 3, 2018
ContributorAuthor
ContributorAuthor
shisama
commented
Dec 5, 2018
ContributorAuthor
Trott
commented
Dec 5, 2018
Member
Landed in 63b0655 |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 5, 2018
PR-URL: nodejs#23400 Refs: nodejs#22160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Dec 7, 2018
joyeecheung pushed a commit
to joyeecheung/node
that referenced
this pull request
Jan 11, 2019
PR-URL: nodejs#23400 Refs: nodejs#22160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#23400 Refs: nodejs#22160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
PR-URL: nodejs#23400 Refs: nodejs#22160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Backport-PR-URL: nodejs#25446 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #22160
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes- [ ] documentation is changed or added