test: correct isReused parameter in test-http-parser

[basti1302]

While backporting #23272 to v10.x and v8.x I noticed that the isReused parameters used in the two reinitialize calls in this test should actually be true instead of false to better reflect the actual usage here (the parser is being reused).

This does not have any effect on the test result here (since we do not test async_hooks calls here) but for the sake of consistency the test should use the API correctly.

Refs: #23272

Checklist

• make -j4 test passes
• commit message follows commit guidelines

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/17732/

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/18602/

[Trott]

@nodejs/http @nodejs/testing Can someone review this?

[Trott]

Resume Build CI again: https://ci.nodejs.org/job/node-test-pull-request/18623/

[Trott]

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18633/

[BridgeAR]

This seems pretty much good to go besides a rebase.

@basti1302 I am very sorry that it took so long to look at this again. With all the PRs incoming it is some times difficult to keep track.

[gireeshpunathil]

ping @basti1302 - can you please rebase this?

[basti1302]

I actually think this has become obsolete with 8876ac5#diff-d4784c96a833a5b56576449c93b866fc / #25094

But I did not have time yet to dig into this again to check if it actually has become obsolete. I don't even fully remember in detail what this was about :)

Honestly though, folks: You have let this sit well over a year but ping me after just a few days of me not responding? I'll take care of it in the next few days or weeks, when I find some time.

[gireeshpunathil]

@basti1302 - thanks no worries. and apologies for the double ping; did not see the previous one!

[basti1302]

Sorry, took me a while to follow up on this. This PR is definitely obsolete now.

First, ece5073 removed the isReused flag from HTTPParser's Reinitialize/Initialize method. Later, the HTTP parser this PR refers to was even replaced by a completely different parser (llhttp) in aa943d0 and ac59dc4.

Closing.