Skip to content

repl: remove unused variable e from try catch - #23449

Closed
khalidadil wants to merge 1 commit into
nodejs:masterfrom
khalidadil:master
Closed

repl: remove unused variable e from try catch#23449
khalidadil wants to merge 1 commit into
nodejs:masterfrom
khalidadil:master

Conversation

@khalidadil

@khalidadilkhalidadil commented Oct 12, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Oct 12, 2018
@gireeshpunathilgireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
WaleedAshraf
WaleedAshraf reviewed Oct 12, 2018
View reviewed changes
Comment threadlib/repl.js
' is not a valid file\n');
}
} catch (e) {
} catch {

@WaleedAshrafWaleedAshrafOct 12, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be logged somewhere?

@thefourtheyethefourtheyeOct 13, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But where ll we log? Whatever we print will be in the REPL.

@Trott

Trott commented Oct 13, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17800

@Trott

Trott commented Oct 13, 2018

Copy link
Copy Markdown
Member

Collaborators, please 👍 here to approve fast-tracking.

@TrottTrott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 13, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 13, 2018
@khalidadil@Trott
repl: remove unused variable e from try catch
f0c5c96
PR-URL: nodejs#23449
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@Trott

Trott commented Oct 13, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Landed in f0c5c96.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@TrottTrott closed this Oct 13, 2018
addaleax pushed a commit that referenced this pull request Oct 14, 2018
@khalidadil@addaleax
repl: remove unused variable e from try catch
4a17d0d
PR-URL: #23449
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@khalidadil@jasnell
repl: remove unused variable e from try catch
4ed1fba
PR-URL: #23449
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@khalidadil@MylesBorins
repl: remove unused variable e from try catch
18060f2
PR-URL: #23449
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebyterecodebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@khalidadil@rvagg
repl: remove unused variable e from try catch
451c160
PR-URL: #23449
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@khalidadil@MylesBorins
repl: remove unused variable e from try catch
4c0e7b4
PR-URL: #23449
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebyterecodebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes
+2 more reviewers
@WaleedAshrafWaleedAshrafWaleedAshraf left review comments
@thefourtheyethefourtheyethefourtheye approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.fast-trackPRs that do not need to wait for 48 hours to land.replIssues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@khalidadil@Trott@thefourtheye@cjihrig@gireeshpunathil@BethGriggs@WaleedAshraf@nodejs-github-bot