Uh oh!
There was an error while loading. Please reload this page.
test: strictEqual correct order for http-information-processing test - #23456
Closed
ivansieder wants to merge 1 commit into
Closed
test: strictEqual correct order for http-information-processing test#23456ivansieder wants to merge 1 commit into
ivansieder wants to merge 1 commit into
Conversation
gireeshpunathil
approved these changes
Oct 12, 2018
cjihrig
approved these changes
Oct 12, 2018
gireeshpunathil
commented
Oct 12, 2018
Member
@ivansieder - is it possible to add a commit message to this PR? thanks. |
ivansieder
commented
Oct 12, 2018
ContributorAuthor
@gireeshpunathil isn't that already added? added the commit with the expected commit message and followed the guidelines for the PR. Did I miss something else there? |
jasnell
approved these changes
Oct 12, 2018
Trott
commented
Oct 13, 2018
Member
thefourtheye
approved these changes
Oct 13, 2018
Trott
commented
Oct 13, 2018
Member
Collaborators, please 👍 here to approve fast-tracking. |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 13, 2018
PR-URL: nodejs#23456 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Trott
commented
Oct 13, 2018
Member
Landed in 84b21eb. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
addaleax pushed a commit
that referenced
this pull request
Oct 14, 2018
PR-URL: #23456 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
jasnell pushed a commit
that referenced
this pull request
Oct 17, 2018
PR-URL: #23456 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 30, 2018
PR-URL: #23456 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Closed
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #23456 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #23456 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for one test, inside the test/parallel/test-http-information-processing.js, the assert.strictEqual() had the wrong order
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes