Uh oh!
There was an error while loading. Please reload this page.
doc: document key encryption options - #23632
Conversation
Uh oh!
There was an error while loading. Please reload this page.
thefourtheye
commented
Oct 13, 2018
/ping @nodejs/crypto |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bnoordhuis
commented
Nov 19, 2018
@tniessen Do you plan to follow up? This looks good to go once you incorporate the review feedback. |
061ba26 to
a94f159Comparetniessen
commented
Nov 25, 2018
@nodejs/crypto @nodejs/documentation PTAL. |
Uh oh!
There was an error while loading. Please reload this page.
sam-github
left a comment
There was a problem hiding this comment.
Text is informative, and LGTM. I leave it to you to decide to address (or not) the comment on duplicate docs.
Uh oh!
There was an error while loading. Please reload this page.
a94f159 to
464b674Comparetniessen
commented
Jan 4, 2019
Thanks for reviewing and sorry about the long delay, I figured it made sense to wait until the key object API had been finalized. That also took care of the duplication you were worried about, @sam-github. I didn't change the text itself, I just moved it to |
Uh oh!
There was an error while loading. Please reload this page.
tniessen
commented
Jan 5, 2019
Landed in 345d3f3, thanks for reviewing! |
PR-URL: #23632 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
PR-URL: nodejs#23632 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
PR-URL: nodejs#23632 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
There is very little documentation on the supported encryption options. This should be enough for most use cases.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes