crypto: simplify internal state handling by tniessen · Pull Request #23648 · nodejs/node

tniessen · 2018-10-13T21:18:32Z

Uninitialized DH instances are never exposed to users, so this condition should always be true.

(This also increases coverage 🎉)

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Uninitialized instances are not exposed to users, so this condition should always be true.

nodejs-github-bot · 2018-10-13T21:18:33Z

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1235/pipeline

bnoordhuis

LGTM

I suspect you could get rid of initialised_ altogether since at no point should instances where initialised_ == true leak to JS land.

tniessen · 2018-10-14T21:44:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/17857/

Uninitialized instances are not exposed to users, so this condition should always be true. PR-URL: #23648 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

tniessen · 2018-10-17T16:50:37Z

Landed in e2f58c7.

As pointed out by Ben Noordhuis, this internal field can be removed since all instances are initialised when exposed to users. Refs: nodejs#23648

Uninitialized instances are not exposed to users, so this condition should always be true. PR-URL: #23648 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

As pointed out by Ben Noordhuis, this internal field can be removed since all instances are initialized when exposed to users. PR-URL: #23717 Refs: #23648 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

refack · 2018-10-20T02:05:02Z

This borkes Travis that uses unsupported 😣GCC 4.8

../src/node_crypto.cc:3641:29: error: no matching function for call to 'get'
return sign->CheckThrow(std::get<Error>(ret));
^~~~~~~~~~~~~~~
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/utility:142:5: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Int'
get(std::pair<_Tp1, _Tp2>& __in) noexcept
^
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/utility:147:5: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Int'
get(std::pair<_Tp1, _Tp2>&& __in) noexcept
^
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/utility:152:5: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Int'
get(const std::pair<_Tp1, _Tp2>& __in) noexcept
^
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/array:268:5: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Int'
get(array<_Tp, _Nm>& __arr) noexcept
^
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/array:277:5: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Int'

refack · 2018-10-20T02:33:53Z

Suggested fix in #23778