test: fix calls of deprecated assert methods by prog1dev · Pull Request #23673 · nodejs/node

prog1dev · 2018-10-15T17:10:18Z

Just went through assert docs and fixed calls of deprecated methods in tests:

Use assert.strictEqual instead of deprecated assert.equal
Use assert.fail([message]) instead of deprecated assert.fail(actual, expected[, message[, operator[, stackStartFn]]])

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

test

prog1dev · 2018-11-01T15:30:34Z

Could you guys review this please?
@vsemozhetbyt @lpinca @richardlau

vsemozhetbyt · 2018-11-01T15:55:45Z

I am only confident enough to humbly ping @nodejs/testing, @nodejs/assert and maybe @BridgeAR.

BridgeAR

LGTM with my comment addressed.

BridgeAR · 2018-11-01T16:19:51Z

@vsemozhetbyt thanks for the ping.

vsemozhetbyt · 2018-11-01T17:34:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/18281/

Trott · 2018-11-06T06:11:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/18355/

prog1dev · 2018-11-10T07:47:52Z

ci build is green

PR-URL: nodejs#23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>

refack · 2018-11-10T16:47:58Z

Landed in 04ccc98...53d424a 🎉

PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs#23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>

nodejs-github-bot added test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Oct 15, 2018

prog1dev force-pushed the test/remove_depricated_assert_equal_method branch from 35ab12b to b235d9fCompare October 15, 2018 18:04

prog1dev changed the title ~~test: remove assert.equal from test-tty-get-color-depth.js test~~test: remove calls of deprecated assert methodsOct 15, 2018

prog1dev force-pushed the test/remove_depricated_assert_equal_method branch from b235d9f to 1e137d1Compare October 15, 2018 18:15

prog1dev force-pushed the test/remove_depricated_assert_equal_method branch from 1e137d1 to 76f0ba9Compare October 28, 2018 14:24

BridgeAR approved these changes Nov 1, 2018
View reviewed changes

Comment threadtest/async-hooks/init-hooks.js Outdated

prog1dev force-pushed the test/remove_depricated_assert_equal_method branch from 76f0ba9 to 9a71b82Compare November 1, 2018 17:23

Trott reviewed Nov 2, 2018
View reviewed changes

Comment threadtest/pseudo-tty/test-tty-get-color-depth.js Outdated

prog1dev force-pushed the test/remove_depricated_assert_equal_method branch from 9a71b82 to d2421b2Compare November 4, 2018 22:02

prog1dev changed the title ~~test: remove calls of deprecated assert methods~~test: fix calls of deprecated assert methodsNov 4, 2018

refack approved these changes Nov 10, 2018
View reviewed changes

prog1dev added 2 commits November 10, 2018 11:45

test: use assert.strictEqual instead of assert.equal
936ac68
PR-URL: nodejs#23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>

test: fix uses of deprecated assert.fail with multiple args
53d424a
PR-URL: nodejs#23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>

refack force-pushed the test/remove_depricated_assert_equal_method branch from d2421b2 to 53d424aCompare November 10, 2018 16:47

refack merged commit 53d424a into nodejs:masterNov 10, 2018

prog1dev deleted the test/remove_depricated_assert_equal_method branch November 10, 2018 19:41

BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
test: use assert.strictEqual instead of assert.equal
2b0410a
PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>

BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
test: fix uses of deprecated assert.fail with multiple args
9af7ad5
PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>

BridgeAR mentioned this pull request Nov 14, 2018
Release proposal: v11.2 #24350
Merged

kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
test: use assert.strictEqual instead of assert.equal
3e14526
PR-URL: nodejs#23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>

kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
test: fix uses of deprecated assert.fail with multiple args
59ccf58
PR-URL: nodejs#23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>

codebytere pushed a commit that referenced this pull request Dec 14, 2018
test: use assert.strictEqual instead of assert.equal
8209ecd
PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>

codebytere pushed a commit that referenced this pull request Dec 14, 2018
test: fix uses of deprecated assert.fail with multiple args
a3289bd
PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>

MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
test: use assert.strictEqual instead of assert.equal
c417c7a
PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>

MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
test: fix uses of deprecated assert.fail with multiple args
4054c24
PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>

codebytere mentioned this pull request Jan 4, 2019
v10.15.1 proposal #25346
Merged

Navigation Menu

Uh oh!

Uh oh!

test: fix calls of deprecated assert methods - #23673

test: fix calls of deprecated assert methods#23673
refack merged 2 commits into
nodejs:masterfrom
prog1dev:test/remove_depricated_assert_equal_method

prog1dev commented Oct 15, 2018•
edited
Loading

Uh oh!

prog1dev commented Nov 1, 2018

Uh oh!

vsemozhetbyt commented Nov 1, 2018•
edited
Loading

Uh oh!

BridgeAR left a comment

Uh oh!

Uh oh!

BridgeAR commented Nov 1, 2018

Uh oh!

vsemozhetbyt commented Nov 1, 2018

Uh oh!

Uh oh!

Trott commented Nov 6, 2018

Uh oh!

prog1dev commented Nov 10, 2018

Uh oh!

refack commented Nov 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

prog1dev commented Oct 15, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Uh oh!

prog1dev commented Nov 1, 2018

Uh oh!

vsemozhetbyt commented Nov 1, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BridgeAR commented Nov 1, 2018

Uh oh!

vsemozhetbyt commented Nov 1, 2018

Uh oh!

Uh oh!

Trott commented Nov 6, 2018

Uh oh!

prog1dev commented Nov 10, 2018

Uh oh!

refack commented Nov 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

prog1dev commented Oct 15, 2018•
edited
Loading

vsemozhetbyt commented Nov 1, 2018•
edited
Loading