Uh oh!
There was an error while loading. Please reload this page.
deps: update libuv to 1.2.0 - #237
Conversation
piscisaureus
commented
Jan 5, 2015
Probably unrelated but: |
piscisaureus
commented
Jan 5, 2015
lgtm |
PR-URL: nodejs#237 Reviewed-By: Bert Belder <bertbelder@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
saghul
commented
Jan 5, 2015
LGTM. (and tests pass here on OSX, FWIW) |
bnoordhuis
commented
Jan 5, 2015
@piscisaureus Curiously enough, the same test is failing on the CI. I've been going over the changes in libuv but I don't see an obvious culprit. |
bnoordhuis
commented
Jan 6, 2015
@piscisaureus I let the CI do some ad hoc bisecting and it looks like the regression was introduced in commit 94e1475, the joyent/v0.12 merge. Maybe you can run a |
cjihrig
commented
Jan 6, 2015
I'll look into this too. I recently changed that test in b636ba8. It works fine on OS X, but fails on Windows. |
bnoordhuis
commented
Jan 6, 2015
@cjihrig It's probably unrelated but there was a merge conflict around line 840 in lib/net.js when I did the merge. It's possible I screwed up conflict resolution although it doesn't look like it (and like you say, the test passes on other platforms.) |
cjihrig
commented
Jan 6, 2015
The problem seems to be the removal of this logic. @piscisaureus any clue why that would leave an extra handle around on Windows? It was removed to try to eliminate hard coded IPv4 addresses. |
R=@piscisaureus or @saghul?