tools: add script to lint commit messages

[richardlau]

Currently the "first PR commit message" linting is only done on Travis. This PR attempts to
decouple the logic from Travis and capture the logic in a bash shell script so that it can be
run locally.

I haven't (yet) added the scripts to Makefile or vcbuild.bat as the script requires git, node,
npm and npx being in $PATH.

Refs: #22452

Checklist

• commit message follows commit guidelines

[nodejs-github-bot]

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1296/pipeline

[addaleax]

grep -q?

[addaleax]

What if there is no such remote?

[richardlau]

Good question. I think that's why the Travis build failed 😆 .

[richardlau]

Haha, that didn't work on Travis:

The command "make lint" exited with 0.
0.03s$ bash tools/lint-commit-message.sh
Target branch is master
Fetching upstream remote fatal: No path specified. See 'man git-pull' for valid url syntax
fatal: Not a valid object name /master
No commits found to lint.

[richardlau]

Fixed Travis:

[lundibundi]

Maybe use FIRST_COMMIT (or at least singular COMMIT) for clarity?

[lundibundi]

I'd note that it only lints first commit message. (It'd stop those who don't know that from wasting their time on fixing every commit they have in the branch)

[richardlau]

This is the exact message currently on Travis: #23742

I'll change it here.

[lundibundi]

Nit: there is a dot at the end, so I'd suggest to either have the dot in every echo message or in none, just for consistency.

[richardlau]

Addressed nits, but it looks like in the meantime my branch and master have diverged and this is now failing to properly pick up the first commit. Removed author ready and put back in progress to prevent this being merged.

[richardlau]

After thinking about this a bit more, I've come up with an alternative: #24030