Uh oh!
There was an error while loading. Please reload this page.
deps: icu: apply workaround patch to 62.1 for significant digits - #23764
Merged
Conversation
MemberAuthor
for ICU 62 this warning will appear:
This will go away with ICU 63, #23715 because ICU 63 has fixed this issue. |
jasnell
approved these changes
Oct 19, 2018
srl295force-pushed
the
patch-icu-62-sigdig
branch
from
October 19, 2018 22:58
4b61932 to
6576f41Comparesrl295
commented
Oct 19, 2018
MemberAuthor
@jasnell thanks. Rebased and fixed a linter problem (long line) |
srl295force-pushed
the
patch-icu-62-sigdig
branch
from
October 22, 2018 22:19
6576f41 to
4a21d69Comparerefack
approved these changes
Oct 23, 2018
srl295
commented
Oct 23, 2018
MemberAuthor
srl295force-pushed
the
patch-icu-62-sigdig
branch
from
October 23, 2018 20:33
4a21d69 to
4194b05Comparetargos pushed a commit
that referenced
this pull request
Oct 24, 2018
ICU 62.1 had a bug where certain orders of operations would not work with the minimum significant digit setting. Fixed in ICU 63.1. Applied the following patch from v8. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20063Fixes: #22156 PR-URL: #23764 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Nov 2, 2018
MylesBorins
commented
Nov 26, 2018
Contributor
@srl295 I've landed this on 8.x and 10.x staging. Please lmk if it shouldn't have landed |
MylesBorins pushed a commit
that referenced
this pull request
Nov 26, 2018
ICU 62.1 had a bug where certain orders of operations would not work with the minimum significant digit setting. Fixed in ICU 63.1. Applied the following patch from v8. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20063Fixes: #22156 PR-URL: #23764 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 26, 2018
ICU 62.1 had a bug where certain orders of operations would not work with the minimum significant digit setting. Fixed in ICU 63.1. Applied the following patch from v8. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20063Fixes: #22156 PR-URL: #23764 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Closed
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
ICU 62.1 had a bug where certain orders of operations would not work with the minimum significant digit setting. Fixed in ICU 63.1. Applied the following patch from v8. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20063Fixes: #22156 PR-URL: #23764 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
ICU 62.1 had a bug where certain orders of operations would not work with the minimum significant digit setting. Fixed in ICU 63.1. Applied the following patch from v8. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20063Fixes: #22156 PR-URL: #23764 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 29, 2018
ICU 62.1 had a bug where certain orders of operations would not work with the minimum significant digit setting. Fixed in ICU 63.1. Applied the following patch from v8. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20063Fixes: #22156 PR-URL: #23764 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
Merged
This was referenced Dec 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patch from https://chromium.googlesource.com/chromium/deps/icu/+/master/patches/nf_maxsig.patch
from https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503
ICU bug: https://unicode-org.atlassian.net/browse/ICU-20063
Fixes: #22156
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes