Uh oh!
There was an error while loading. Please reload this page.
src: refactor grow_async_ids_stack - #23808
Merged
Merged
Conversation
2 tasks
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Member
There was a problem hiding this comment.
style nit: old_size_in_bytes, new_size_in_bytes
ContributorAuthor
There was a problem hiding this comment.
Ack.
Turned up the level of my IDE's inspection of these to "error".
joyeecheung
approved these changes
Oct 23, 2018
joyeecheung
left a comment
Member
There was a problem hiding this comment.
LGTM with the style nits from @addaleax
refack
commented
Oct 23, 2018
ContributorAuthor
mmarchini
approved these changes
Oct 24, 2018
refackforce-pushed
the
grow_async_ids
branch
2 times, most recently
from
October 24, 2018 16:18
888b26e to
b845fd6Comparerefack
commented
Oct 24, 2018
ContributorAuthor
refactor grow_async_ids_stack PR-URL: nodejs#23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
PR-URL: nodejs#23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
targos pushed a commit
that referenced
this pull request
Oct 26, 2018
refactor grow_async_ids_stack PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
targos pushed a commit
that referenced
this pull request
Oct 26, 2018
PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Closed
targos
commented
Nov 1, 2018
Member
Marking dont-land-on-v11.x until nodejs/build#1542 is fixed |
refack
commented
Nov 1, 2018
ContributorAuthor
@targos there are two more PR that will require GCC4.9 |
refack
commented
Nov 15, 2018
ContributorAuthor
@targos the arm7 issue in ci-release was resolved - https://ci-release.nodejs.org/job/iojs+release/nodes=centos7-arm64-gcc6/3919/ |
targos pushed a commit
that referenced
this pull request
Nov 18, 2018
refactor grow_async_ids_stack PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
targos pushed a commit
that referenced
this pull request
Nov 18, 2018
PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
targos
commented
Nov 18, 2018
Member
@refack thanks! I backported this (and others) to v11.x and confirmed: https://ci-release.nodejs.org/job/iojs+release/3934/nodes=centos7-arm64-gcc6/ |
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
refactor grow_async_ids_stack PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
This was referenced Dec 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
AliasedBuffer::reserve()CI: https://ci.nodejs.org/job/node-test-pull-request/18034/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes