Uh oh!
There was an error while loading. Please reload this page.
doc: update missing deprecation - #23883
Merged
Merged
Conversation
cjihrig referenced
this pull request
Oct 25, 2018
This is an undocumented utility function that is of questionable utility. Fixes: #18391 PR-URL: #23760 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
richardlau
approved these changes
Oct 25, 2018
jasnell
commented
Oct 25, 2018
Member
ugh... forgot about that darn dep code update. |
jasnell
approved these changes
Oct 25, 2018
vsemozhetbyt
approved these changes
Oct 25, 2018
vsemozhetbyt
commented
Oct 25, 2018
Contributor
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
mmarchini
approved these changes
Oct 25, 2018
jasnell
commented
Oct 25, 2018
Member
4 tasks
trivikr
approved these changes
Oct 26, 2018
jasnell
commented
Oct 26, 2018
Member
lpinca
approved these changes
Oct 26, 2018
cjihrig
commented
Oct 27, 2018
ContributorAuthor
Green resumed CI: https://ci.nodejs.org/job/node-test-pull-request/18179/ |
The deprecation code was not updated when landing the PR. PR-URL: nodejs#23883 Refs: nodejs#23760 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deprecation code was not updated when landing the PR.
Refs: #23760
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes