Uh oh!
There was an error while loading. Please reload this page.
doc: add decode & encode method in querystring.md - #23889
Closed
ZYSzys wants to merge 1 commit into
Closed
Conversation
mihalskiy
approved these changes
Oct 26, 2018
ZYSzys
commented
Feb 14, 2019
MemberAuthor
/cc @nodejs/documentation . Should we add |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
joyeecheung
commented
Feb 14, 2019
Member
I cannot dig up the exact links but I vaguely remember this was brought up once and the decision was to keep the two undocumented, deprecate them, and eventually remove them. |
jasnell
approved these changes
Feb 14, 2019
vsemozhetbyt
commented
Mar 8, 2019
Contributor
Is this ready to be landed? |
BridgeAR
approved these changes
Mar 8, 2019
BridgeAR
left a comment
Member
There was a problem hiding this comment.
I guess it does not hurt to have the alias in place.
vsemozhetbyt
commented
Mar 10, 2019
Contributor
vsemozhetbyt
commented
Mar 10, 2019
Contributor
Landed in fb54968 |
vsemozhetbyt pushed a commit
that referenced
this pull request
Mar 10, 2019
PR-URL: #23889 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit
that referenced
this pull request
Mar 13, 2019
PR-URL: #23889 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit
that referenced
this pull request
Mar 13, 2019
PR-URL: #23889 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit
that referenced
this pull request
Mar 14, 2019
PR-URL: #23889 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit
that referenced
this pull request
Apr 16, 2019
PR-URL: #23889 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found there are
querystring.decodemethod andquerystring.encodein the querystring.js but they are not shown on the document. So maybe we need to add these right ?Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes