Uh oh!
There was an error while loading. Please reload this page.
doc: add readable and writable property to Readable and Writable - #23924
doc: add readable and writable property to Readable and Writable#23924dexterleng wants to merge 0 commit into
Conversation
There was a problem hiding this comment.
It's a property, not a function, so it does not return a value.
There was a problem hiding this comment.
It's a property, not a function, so it does not return a value.
There was a problem hiding this comment.
Properties should be ordered alphabetically in the docs, so this is in the wrong place. It needs to appear above the other writable.writable* properties.
There was a problem hiding this comment.
Properties should be ordered alphabetically in the docs, so this is in the wrong place. It needs to appear above the other readable.readable* properties.
Trott
commented
Oct 27, 2018
Hi, @dexterleng! Welcome and thanks for the pull request! Documentation changes can attract a lot of comments, which sometimes surprises and even frustrates people. Try to be patient and to not get discouraged. Thanks again! |
c0cd519 to
35ed66cComparedexterleng
commented
Oct 28, 2018
Oops. I forced pushed and broke the commit history. Opening a new PR. |
Issue #21431
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes