Uh oh!
There was an error while loading. Please reload this page.
doc: revise CHANGELOG.md text - #23988
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Make the text shorter and clearer.
trivikr
approved these changes
Oct 31, 2018
| @@ -1,11 +1,5 @@ | |||
| # Node.js Changelog | |||
| <!--lint disable maximum-line-length--> | |||
Contributor
There was a problem hiding this comment.
We can drop this instruction because long HTML lines are OK, right?
MemberAuthor
There was a problem hiding this comment.
I don't think there's any line length linting going on in markdown files (outside of code blocks) at this time.
vsemozhetbyt
approved these changes
Oct 31, 2018
lpinca
approved these changes
Oct 31, 2018
jasnell
approved these changes
Nov 1, 2018
Trott
commented
Nov 2, 2018
MemberAuthor
Landed in 34f164f |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Nov 2, 2018
Make the text shorter and clearer. PR-URL: nodejs#23988 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 2, 2018
Make the text shorter and clearer. PR-URL: #23988 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 15, 2018
MylesBorins pushed a commit
that referenced
this pull request
Nov 27, 2018
Make the text shorter and clearer. PR-URL: #23988 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
Make the text shorter and clearer. PR-URL: #23988 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 29, 2018
Make the text shorter and clearer. PR-URL: #23988 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Dec 3, 2018
Make the text shorter and clearer. PR-URL: #23988 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the text shorter and clearer.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes