Skip to content

Simple project messaging. - #24

Closed
mikeal wants to merge 1 commit into
nodejs:v0.12from
mikeal:readme-messaging
Closed

Simple project messaging.#24
mikeal wants to merge 1 commit into
nodejs:v0.12from
mikeal:readme-messaging

Conversation

@mikeal

@mikealmikeal commented Dec 2, 2014

Copy link
Copy Markdown
Contributor

This should put to bed some of the wilder speculation we've seen.

@rvagg

rvagg commented Dec 2, 2014

Copy link
Copy Markdown
Member

+1 for putting to bed "Evented I/O for V8 javascript", I've always hated that title

@max-mapper

max-mapper commented Dec 2, 2014

Copy link
Copy Markdown
Contributor

your commit should be docs: add simple project messaging to readme :)

@mikeal

mikeal commented Dec 2, 2014

Copy link
Copy Markdown
ContributorAuthor

how do i alter commit messages after the fact?

@TJkrusinski

TJkrusinski commented Dec 2, 2014

Copy link
Copy Markdown

git commit --amend

@mikeal

mikeal commented Dec 2, 2014

Copy link
Copy Markdown
ContributorAuthor

@TJkrusinski thanks! :)

@TJkrusinski

TJkrusinski commented Dec 2, 2014

Copy link
Copy Markdown

no problem!

@indutny

indutny commented Dec 2, 2014

Copy link
Copy Markdown
Member

LGTM

@mikealmikeal mentioned this pull request Dec 2, 2014
Closed
@ralphtheninja

ralphtheninja commented Dec 2, 2014

Copy link
Copy Markdown

@mikeal Are you working on the governance section in https://github.com/mikeal/io.js/blob/readme-messaging/CONTRIBUTING.md#governance ?

@mikeal

mikeal commented Dec 2, 2014

Copy link
Copy Markdown
ContributorAuthor

@ralphtheninja wrong branch :) https://github.com/mikeal/io.js/blob/contribution-policy/CONTRIBUTING.md#governance

@ralphtheninja

ralphtheninja commented Dec 2, 2014

Copy link
Copy Markdown

👍

KyleAMathews
KyleAMathews reviewed Dec 2, 2014
View reviewed changes
Comment threadREADME.md

@KyleAMathewsKyleAMathewsDec 2, 2014

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph is a bit awkward.

@kevinohara80kevinohara80Dec 3, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I think it's supposed to say io.js is under the "open governance model" but it reads like node.js is. Not trying to be nitpicky. This is a pretty important paragraph.

@rvaggrvaggDec 3, 2014

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinohara80 +1, would you or @KyleAMathews mind putting in a PR to clarify this?

@kevinohara80kevinohara80Dec 3, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing that now

@kevinohara80kevinohara80Dec 3, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #36

mikeal added a commit that referenced this pull request Dec 2, 2014
@mikeal@indutny
docs: simple project messaging.
51514c8
Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: #24
@indutny

indutny commented Dec 2, 2014

Copy link
Copy Markdown
Member

Landed in 51514c8! Thank you.

@indutnyindutny closed this Dec 2, 2014
@Fishrock123Fishrock123 mentioned this pull request Dec 3, 2014
Closed
kevinohara80 added a commit to kevinohara80/io.js that referenced this pull request Dec 10, 2014
@kevinohara80
docs: reword project messaging
0ac6796
rewords project messaging in README to make the overall
project messaging a bit clearer. More discussion to be
found in nodejs#24
bnoordhuis pushed a commit that referenced this pull request Dec 10, 2014
@kevinohara80@bnoordhuis
docs: reword project messaging
6f1d0a8
Rewords project messaging in README to make the overall project
messaging a bit clearer. More discussion to be found in #24.
PR-URL: #36
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@jianpingwjianpingw mentioned this pull request Dec 13, 2015
Closed
@rupamkhaitanrupamkhaitan mentioned this pull request Jun 27, 2016
Closed
@sclinedesclinede mentioned this pull request Sep 6, 2017
Closed
@spurreiterspurreiter mentioned this pull request Jun 4, 2018
Closed
@cornopaezcornopaez mentioned this pull request Sep 28, 2018
Closed
@arxeissarxeiss mentioned this pull request Aug 16, 2019
Closed
@snyk-botsnyk-bot mentioned this pull request Jun 11, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Jul 21, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Sep 12, 2022
Open
@tniessentniessen mentioned this pull request Sep 12, 2022
Closed
@theanarkhtheanarkh mentioned this pull request Oct 18, 2022
Closed
@snyk-botsnyk-bot mentioned this pull request Jan 20, 2023
Open
@ashly1111111ashly1111111 mentioned this pull request Feb 2, 2023
Open
@Michaela813Michaela813 mentioned this pull request Feb 3, 2023
Open
@SanchitMahajan236SanchitMahajan236 mentioned this pull request Feb 17, 2023
Merged
@snyk-botsnyk-bot mentioned this pull request Feb 18, 2023
Open
@snyk-botsnyk-bot mentioned this pull request Mar 3, 2023
Open
@davidmatherdavidmather mentioned this pull request Mar 15, 2023
Open
@Bank4500Bank4500 mentioned this pull request Mar 22, 2023
Open
@leonardoadameleonardoadame mentioned this pull request May 3, 2023
Merged
@snyk-botsnyk-bot mentioned this pull request May 30, 2023
Open
@RenukalochRenukaloch mentioned this pull request Aug 1, 2023
Open
@pranathi-nallamillipranathi-nallamilli mentioned this pull request Aug 4, 2023
Open
@JCsomeShotsJCsomeShots mentioned this pull request Sep 20, 2023
Open
@maverick3312maverick3312 mentioned this pull request Sep 28, 2023
Open
@Alexey0312Alexey0312 mentioned this pull request Sep 29, 2023
Open
@CharliesAngel1CharliesAngel1 mentioned this pull request Oct 15, 2023
Open
@AliceSofAliceSof mentioned this pull request Nov 14, 2023
Open
@B020239B020239 mentioned this pull request Mar 9, 2024
Open
@ronking-zhuronking-zhu mentioned this pull request Oct 13, 2025
Closed
mcollina added a commit to mcollina/node that referenced this pull request Mar 16, 2026
@mcollina
vfs: address code review feedback from@jasnell
9e8479b
- Use undefined instead of null for lazy-loaded SEAProvider
- Add validateBoolean for moduleHooks and virtualCwd options
- Use template literal for path concatenation
- Convert VirtualReadStream to use private class fields
- Cache DateNow() result in MemoryEntry constructor
Addresses review comments nodejs#18, nodejs#19, nodejs#21, nodejs#23, nodejs#24, nodejs#29.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mikeal@rvagg@max-mapper@TJkrusinski@indutny@ralphtheninja@KyleAMathews@kevinohara80