Skip to content

http2: add test for ERR_HTTP2_ORIGIN_LENGTH - #24014

Closed
trivikr wants to merge 1 commit into
nodejs:masterfrom
trivikr:test-origin-length
Closed

http2: add test for ERR_HTTP2_ORIGIN_LENGTH#24014
trivikr wants to merge 1 commit into
nodejs:masterfrom
trivikr:test-origin-length

Conversation

@trivikr

@trivikrtrivikr commented Nov 1, 2018

Copy link
Copy Markdown
Member

Adds test for ERR_HTTP2_ORIGIN_LENGTH
It's not covered in the latest coverage

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2018

Copy link
Copy Markdown
Collaborator

@trivikr build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1448/pipeline

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 1, 2018
@trivikrtrivikr self-assigned this Nov 1, 2018
@trivikrtrivikr added the http2 Issues or PRs related to the http2 subsystem. label Nov 1, 2018
@trivikr

trivikr commented Nov 1, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/18279/

@trivikrtrivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 1, 2018
@trivikr

trivikr commented Nov 3, 2018

Copy link
Copy Markdown
MemberAuthor

Closing reason: This is a backup PR for my talk about writing unit tests at NodeConfEU
If time permits, I plan to post this code change live (in another PR) at around 11:20 UTC on Tuesday November 5th, 2018. If you're free at that time, do review it live and post some comments 😊

@trivikrtrivikr closed this Nov 3, 2018
@trivikr
trivikr deleted the test-origin-length branch August 31, 2023 14:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

@trivikrtrivikr

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.http2Issues or PRs related to the http2 subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@trivikr@nodejs-github-bot@jasnell@addaleax@lpinca@cjihrig