Uh oh!
There was an error while loading. Please reload this page.
build: use BUILDTYPE in bench-addons-build targets - #24033
Closed
danbev wants to merge 1 commit into
Closed
Conversation
danbev
commented
Nov 2, 2018
ContributorAuthor
richardlau
approved these changes
Nov 2, 2018
refack
reviewed
Nov 2, 2018
Uh oh!
There was an error while loading. Please reload this page.
refack
suggested changes
Nov 2, 2018
refack
left a comment
Contributor
There was a problem hiding this comment.
Should use process.features.debug
Uh oh!
There was an error while loading. Please reload this page.
danbev
commented
Nov 6, 2018
ContributorAuthor
Uh oh!
There was an error while loading. Please reload this page.
Trott
reviewed
Nov 6, 2018
Uh oh!
There was an error while loading. Please reload this page.
danbev
commented
Nov 6, 2018
ContributorAuthor
danbevforce-pushed
the
debug_benchmark_napi_buildtype
branch
from
November 6, 2018 17:37
cbb0428 to
430317dCompareThis commit uses the BUILDTYPE for the benchmark targets that currently explicitly use Release as the build type. The motivation for this change is allows switching between debug builds and release builds using the bench-addons-clean/bench-addons-build targets.
danbevforce-pushed
the
debug_benchmark_napi_buildtype
branch
from
November 8, 2018 04:43
430317d to
1fd4d56Comparejasnell
approved these changes
Nov 10, 2018
Trott
commented
Nov 11, 2018
Member
@refack This looks like it has addressed your comment. Is your request for changes dismiss-able at this point? |
refack
approved these changes
Nov 11, 2018
refack
commented
Nov 11, 2018
Contributor
Quick sanity CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1577/ |
refack
commented
Nov 11, 2018
Contributor
Landed in ce6ec36 |
refack pushed a commit
that referenced
this pull request
Nov 11, 2018
This commit uses the BUILDTYPE for the benchmark targets that currently explicitly use Release as the build type. The motivation for this change is allows switching between debug builds and release builds using the bench-addons-clean/bench-addons-build targets. PR-URL: #24033 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Nov 14, 2018
This commit uses the BUILDTYPE for the benchmark targets that currently explicitly use Release as the build type. The motivation for this change is allows switching between debug builds and release builds using the bench-addons-clean/bench-addons-build targets. PR-URL: #24033 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
kiyomizumia pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
This commit uses the BUILDTYPE for the benchmark targets that currently explicitly use Release as the build type. The motivation for this change is allows switching between debug builds and release builds using the bench-addons-clean/bench-addons-build targets. PR-URL: nodejs#24033 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 15, 2018
This was referenced Nov 15, 2018
codebytere pushed a commit
that referenced
this pull request
Jan 12, 2019
This commit uses the BUILDTYPE for the benchmark targets that currently explicitly use Release as the build type. The motivation for this change is allows switching between debug builds and release builds using the bench-addons-clean/bench-addons-build targets. PR-URL: #24033 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit uses the
BUILDTYPEfor the benchmark targets that currentlyexplicitly use
Releaseas the build type.The motivation for this change is allows switching between debug builds
and release builds using the
bench-addons-clean/bench-addons-buildtargets.
@nodejs/build-files
make -j4 test(UNIX), orvcbuild test(Windows) passes