Uh oh!
There was an error while loading. Please reload this page.
http2: multiple improvements - #24063
Closed
jasnell wants to merge 3 commits into
Closed
Conversation
MemberAuthor
jasnellforce-pushed
the
http2-js-improvements
branch
from
November 4, 2018 05:22
2747fde to
b7d8d9eComparejasnell
commented
Nov 6, 2018
MemberAuthor
On this PR... I plan to pull the destructuring changes back out as that is still a bit too expensive and is offsetting the performance improvement from other bits of the code. |
jasnellforce-pushed
the
http2-js-improvements
branch
2 times, most recently
from
November 7, 2018 19:08
53105f7 to
eeb665eCompareMemberAuthor
jasnellforce-pushed
the
http2-js-improvements
branch
from
November 7, 2018 19:20
eeb665e to
3bc2c94Comparejasnell
commented
Nov 10, 2018
MemberAuthor
Resumed CI: https://ci.nodejs.org/job/node-test-pull-request/18510/ /cc @nodejs/http2 |
Trott
commented
Nov 15, 2018
Member
Needs a rebase to eliminate conflicts? |
jasnell
commented
Nov 15, 2018
via email
MemberAuthor
Yep, will get it this week
On Nov 14, 2018 19:24, "Rich Trott" <notifications@github.com> wrote:
Needs a rebase to eliminate conflicts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24063 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAa2eZAq2IbfAbzzJrPGeoE9oZbMFD3Jks5uvN5ngaJpZM4YM6pw>
. |
jasnellforce-pushed
the
http2-js-improvements
branch
from
November 19, 2018 17:20
3bc2c94 to
aecc38cComparejasnell
commented
Nov 19, 2018
MemberAuthor
New CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/18763/ |
jasnell
commented
Nov 19, 2018
MemberAuthor
Ping @nodejs/http2 ... I plan to get this landed by Wednesday this week. |
jasnell
commented
Nov 19, 2018
MemberAuthor
jasnell
commented
Nov 20, 2018
MemberAuthor
Make the http2 binding a bit more efficient by setting the callback functions once when the module is loaded rather than for each `Http2Session` and `Http2Stream`.
jasnellforce-pushed
the
http2-js-improvements
branch
from
November 21, 2018 15:41
8481e58 to
6da3da2Comparejasnell added a commit
that referenced
this pull request
Nov 21, 2018
PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
jasnell added a commit
that referenced
this pull request
Nov 21, 2018
Make the http2 binding a bit more efficient by setting the callback functions once when the module is loaded rather than for each `Http2Session` and `Http2Stream`. PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
jasnell added a commit
that referenced
this pull request
Nov 21, 2018
PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
jasnell
commented
Nov 21, 2018
MemberAuthor
targos pushed a commit
that referenced
this pull request
Nov 21, 2018
PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
targos pushed a commit
that referenced
this pull request
Nov 21, 2018
Make the http2 binding a bit more efficient by setting the callback functions once when the module is loaded rather than for each `Http2Session` and `Http2Stream`. PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
targos pushed a commit
that referenced
this pull request
Nov 21, 2018
PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
Make the http2 binding a bit more efficient by setting the callback functions once when the module is loaded rather than for each `Http2Session` and `Http2Stream`. PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
This was referenced Dec 7, 2018
codebytere
commented
Jan 13, 2019
Member
@jasnell could you backport this to |
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Make the http2 binding a bit more efficient by setting the callback functions once when the module is loaded rather than for each `Http2Session` and `Http2Stream`. PR-URL: nodejs#24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple improvements throughout the http2 js code
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes