Uh oh!
There was an error while loading. Please reload this page.
tools: lint to wrap markdown at 80 characters - #24094
Closed
Trott wants to merge 2 commits into
Closed
Conversation
This is in preparation for a markdown lint rule requiring lines to be wrapped at 80 characters.
4 tasks
richardlau
approved these changes
Nov 5, 2018
refack
approved these changes
Nov 5, 2018
refack
commented
Nov 5, 2018
Contributor
I could add a prettify/uglify step to the rollup if someone asks 🤷♂️ |
lpinca
approved these changes
Nov 5, 2018
Trott added a commit
to Trott/io.js
that referenced
this pull request
Nov 7, 2018
This is in preparation for a markdown lint rule requiring lines to be wrapped at 80 characters. PR-URL: nodejs#24094 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott added a commit
to Trott/io.js
that referenced
this pull request
Nov 7, 2018
PR-URL: nodejs#24094 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
commented
Nov 7, 2018
MemberAuthor
Landed in 1368eb8...c3809ff (Aforementioned whitespace issues auto-squelched in the process of landing with ncu.) |
BridgeAR pushed a commit
that referenced
this pull request
Nov 14, 2018
This is in preparation for a markdown lint rule requiring lines to be wrapped at 80 characters. PR-URL: #24094 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #24094 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
kiyomizumia pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
This is in preparation for a markdown lint rule requiring lines to be wrapped at 80 characters. PR-URL: nodejs#24094 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
kiyomizumia pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#24094 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Nov 15, 2018
codebytere pushed a commit
that referenced
this pull request
Nov 29, 2018
This is in preparation for a markdown lint rule requiring lines to be wrapped at 80 characters. PR-URL: #24094 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #24094 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 29, 2018
This is in preparation for a markdown lint rule requiring lines to be wrapped at 80 characters. PR-URL: #24094 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #24094 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Dec 3, 2018
This is in preparation for a markdown lint rule requiring lines to be wrapped at 80 characters. PR-URL: #24094 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 3, 2018
PR-URL: #24094 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what the whitespace thrashing in lint-md.js is all about, but it's a generated file so I'm reluctant to "fix" it. /cc @refack
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes