Skip to content

doc: update crypto examples to not use deprecated api - #24107

Closed
mayankasthana wants to merge 1 commit into
nodejs:masterfrom
mayankasthana:crypto-docs-deprecated-examples
Closed

doc: update crypto examples to not use deprecated api#24107
mayankasthana wants to merge 1 commit into
nodejs:masterfrom
mayankasthana:crypto-docs-deprecated-examples

Conversation

@mayankasthana

@mayankasthanamayankasthana commented Nov 5, 2018

Copy link
Copy Markdown
Contributor

Updated Cipher and Decipher examples to not use deprecated
crypto.createCipher and crypto.createDecipher in examples and
instead use createCipheriv and createDecipheriv.

Fixes: #24046

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows [commit guidelines]

@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Nov 5, 2018
@refack

refack commented Nov 5, 2018

Copy link
Copy Markdown
Contributor

Hello @mayankasthana, and thank you for the contribution!
If you haven't already, it's recommended you take a look at CONTRIBUTING.md guide (especially the part about "discuss and update"). Customarily PRs are kept open for at least 48 hour so that anyone interested gets a chance to comment or review.
Also documentation changes, while easy to do are more difficult to validate. With code we can write tests and the CI can validate the change. With documentation the only way to validate is with human eyes, so don't be dismayed if you get a lot of feedback.
Anyway thank you for the contribution, and good luck 🥇

P.S. If you have any question you can also feel free to contact me directly.

aduh95
aduh95 approved these changes Nov 9, 2018
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott

Trott commented Nov 10, 2018

Copy link
Copy Markdown
Member

@nodejs/crypto

tniessen
tniessen requested changes Nov 10, 2018
View reviewed changes

@tniessentniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Comment threaddoc/api/crypto.md Outdated
Comment threaddoc/api/crypto.md Outdated
Comment threaddoc/api/crypto.md Outdated
Comment threaddoc/api/crypto.md Outdated
Comment threaddoc/api/crypto.md Outdated
Comment threaddoc/api/crypto.md Outdated
Comment threaddoc/api/crypto.md Outdated
Comment threaddoc/api/crypto.md Outdated
Comment threaddoc/api/crypto.md Outdated
Comment threaddoc/api/crypto.md Outdated
ryzokuken
ryzokuken approved these changes Nov 10, 2018
View reviewed changes

@ryzokukenryzokuken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had been on my personal TODO list for a while but never managed to actually do it.

Thanks!

LGTM after @tniessen's comments are addressed.

@mayankasthana
doc: update crypto examples to not use deprecated api
cf8563e
Updated Cipher and Decipher examples to not use deprecated
`crypto.createCipher` and `crypto.createDecipher` in examples and
instead use `createCipheriv` and `createDecipheriv`.
Fixes: nodejs#24046
@mayankasthana
mayankasthanaforce-pushed the crypto-docs-deprecated-examples branch from b93bf50 to cf8563eCompareNovember 10, 2018 16:22
tniessen
tniessen approved these changes Nov 10, 2018
View reviewed changes

@tniessentniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments have been addressed.

@Trott

Trott commented Nov 19, 2018

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1653/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 19, 2018
@Trott

Trott commented Nov 19, 2018

Copy link
Copy Markdown
Member

Landed in 9730903

@TrottTrott closed this Nov 19, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 19, 2018
@mayankasthana@Trott
doc: update crypto examples to not use deprecated api
9730903
Updated Cipher and Decipher examples to not use deprecated
`crypto.createCipher` and `crypto.createDecipher` in examples and
instead use `createCipheriv` and `createDecipheriv`.
Fixes: nodejs#24046
PR-URL: nodejs#24107
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
targos pushed a commit that referenced this pull request Nov 19, 2018
@mayankasthana@targos
doc: update crypto examples to not use deprecated api
0d8725f
Updated Cipher and Decipher examples to not use deprecated
`crypto.createCipher` and `crypto.createDecipher` in examples and
instead use `createCipheriv` and `createDecipheriv`.
Fixes: #24046
PR-URL: #24107
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@mayankasthana@rvagg
doc: update crypto examples to not use deprecated api
ed78339
Updated Cipher and Decipher examples to not use deprecated
`crypto.createCipher` and `crypto.createDecipher` in examples and
instead use `createCipheriv` and `createDecipheriv`.
Fixes: #24046
PR-URL: #24107
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@mayankasthana@codebytere
doc: update crypto examples to not use deprecated api
8475fb1
Updated Cipher and Decipher examples to not use deprecated
`crypto.createCipher` and `crypto.createDecipher` in examples and
instead use `createCipheriv` and `createDecipheriv`.
Fixes: #24046
PR-URL: #24107
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@mayankasthana@refack
doc: update crypto examples to not use deprecated api
ec59477
Updated Cipher and Decipher examples to not use deprecated
`crypto.createCipher` and `crypto.createDecipher` in examples and
instead use `createCipheriv` and `createDecipheriv`.
Fixes: nodejs#24046
PR-URL: nodejs#24107
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
@codebyterecodebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@mayankasthana@codebytere
doc: update crypto examples to not use deprecated api
7fd4ef7
Updated Cipher and Decipher examples to not use deprecated
`crypto.createCipher` and `crypto.createDecipher` in examples and
instead use `createCipheriv` and `createDecipheriv`.
Fixes: #24046
PR-URL: #24107
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
@beevelopbeevelop mentioned this pull request Jan 29, 2019
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@tniessentniessentniessen approved these changes
@aduh95aduh95aduh95 approved these changes
+1 more reviewer
@ryzokukenryzokukenryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mayankasthana@refack@Trott@jasnell@tniessen@ryzokuken@aduh95@nodejs-github-bot