Uh oh!
There was an error while loading. Please reload this page.
build: only try to run node when it's needed by the target - #24115
Closed
joyeecheung wants to merge 2 commits into
Closed
build: only try to run node when it's needed by the target#24115joyeecheung wants to merge 2 commits into
joyeecheung wants to merge 2 commits into
Conversation
Right now `node -p process.versions.openssl` always gets run in the Makefile even when it's not needed by the target (e.g. `make clean`, `make test-only`). This patch makes it a run time call instead of part of the global expansion.
joyeecheung
commented
Nov 6, 2018
MemberAuthor
richardlau
approved these changes
Nov 6, 2018
joyeecheung
commented
Nov 6, 2018
MemberAuthor
hmm, so the more accurate description is "only try to run node" because make will always attempt to find it, it just does not actually call it until you |
joyeecheung
commented
Nov 6, 2018
MemberAuthor
This also partially addresses #22148 (comment)
The bad build won't be run if you have not touched documentation, or if you are running |
danbev
suggested changes
Nov 6, 2018
Uh oh!
There was an error while loading. Please reload this page.
joyeecheung
commented
Nov 6, 2018
Uh oh!
There was an error while loading. Please reload this page.
joyeecheung
commented
Nov 6, 2018
MemberAuthor
danbev
approved these changes
Nov 6, 2018
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 8, 2018
Right now `node -p process.versions.openssl` always gets run in the Makefile even when it's not needed by the target (e.g. `make clean`, `make test-only`). This patch makes it a run time call instead of part of the global expansion. PR-URL: nodejs#24115 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Trott
commented
Nov 8, 2018
Member
Landed in dc3bc89 |
BridgeAR pushed a commit
that referenced
this pull request
Nov 14, 2018
Right now `node -p process.versions.openssl` always gets run in the Makefile even when it's not needed by the target (e.g. `make clean`, `make test-only`). This patch makes it a run time call instead of part of the global expansion. PR-URL: #24115 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
kiyomizumia pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
Right now `node -p process.versions.openssl` always gets run in the Makefile even when it's not needed by the target (e.g. `make clean`, `make test-only`). This patch makes it a run time call instead of part of the global expansion. PR-URL: nodejs#24115 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This was referenced Nov 15, 2018
codebytere pushed a commit
that referenced
this pull request
Dec 13, 2018
Right now `node -p process.versions.openssl` always gets run in the Makefile even when it's not needed by the target (e.g. `make clean`, `make test-only`). This patch makes it a run time call instead of part of the global expansion. PR-URL: #24115 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 26, 2018
Right now `node -p process.versions.openssl` always gets run in the Makefile even when it's not needed by the target (e.g. `make clean`, `make test-only`). This patch makes it a run time call instead of part of the global expansion. PR-URL: #24115 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now
node -p process.versions.opensslalways gets runin the Makefile even when it's not needed by the target
(e.g.
make clean,make test-only). This patch makes ita run time call instead of part of the global expansion.