Uh oh!
There was an error while loading. Please reload this page.
test: fix strictEqual argument order - #24153
Closed
KaskMartin wants to merge 1 commit into
Closed
Conversation
BridgeAR
approved these changes
Nov 6, 2018
cjihrig
approved these changes
Nov 6, 2018
gireeshpunathil
approved these changes
Nov 6, 2018
trivikr
approved these changes
Nov 7, 2018
gireeshpunathil
commented
Nov 9, 2018
Member
Uh oh!
There was an error while loading. Please reload this page.
KaskMartinforce-pushed
the
fix-test-buffer-slice-assert-argument-order
branch
from
November 10, 2018 10:18
e2e7046 to
414c953Compare
Fix the order of assert.strictEqual() arguments. It should have first argument as the calculated/tested value.
KaskMartinforce-pushed
the
fix-test-buffer-slice-assert-argument-order
branch
from
November 10, 2018 11:35
414c953 to
ad527cdComparejasnell
approved these changes
Nov 10, 2018
Trott
commented
Nov 11, 2018
Member
Trott
commented
Nov 12, 2018
Member
Landed in 8efad19. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 12, 2018
Fix the order of assert.strictEqual() arguments. It should have first argument as the calculated/tested value. PR-URL: nodejs#24153 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Nov 14, 2018
Fix the order of assert.strictEqual() arguments. It should have first argument as the calculated/tested value. PR-URL: #24153 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
kiyomizumia pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
Fix the order of assert.strictEqual() arguments. It should have first argument as the calculated/tested value. PR-URL: nodejs#24153 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 15, 2018
codebytere pushed a commit
that referenced
this pull request
Dec 14, 2018
Fix the order of assert.strictEqual() arguments. It should have first argument as the calculated/tested value. PR-URL: #24153 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 26, 2018
Fix the order of assert.strictEqual() arguments. It should have first argument as the calculated/tested value. PR-URL: #24153 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the order of assert.strictEqual() arguments.
It should have first argument as the calculated/tested value