test: TextDecoder custom inspection

[robin-drexler]

These tests ensure hidden fields are shown when inspecting with
showHidden and that passing negative depth prints simplified value.

Co-authored-by: ZauberNerd zaubernerd@zaubernerd.de

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[gireeshpunathil]

CI: https://ci.nodejs.org/job/node-test-pull-request/18521/

[gireeshpunathil]

@robin-drexler - CI fails for this PR, which I guess is related, please have a look:

04:21:38 not ok 1993 parallel/test-whatwg-encoding-textdecoder
04:21:38 ---
04:21:38 duration_ms: 0.165
04:21:38 severity: fail
04:21:38 exitcode: 1
04:21:38 stack: |-
04:21:38 internal/encoding.js:435
04:21:38 throw new ERR_NO_ICU('"fatal" option');
04:21:38 ^
04:21:38 04:21:38 TypeError [ERR_NO_ICU]: "fatal" option is not supported on Node.js compiled without ICU
04:21:38 at new TextDecoder (internal/encoding.js:435:17)
04:21:38 at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_withoutintl_x64/test/parallel/test-whatwg-encoding-textdecoder.js:95:15)
04:21:38 at Module._compile (internal/modules/cjs/loader.js:722:30)
04:21:38 at Object.Module._extensions..js (internal/modules/cjs/loader.js:733:10)
04:21:38 at Module.load (internal/modules/cjs/loader.js:620:32)
04:21:38 at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
04:21:38 at Function.Module._load (internal/modules/cjs/loader.js:552:3)
04:21:38 at Function.Module.runMain (internal/modules/cjs/loader.js:775:12)
04:21:38 at startup (internal/bootstrap/node.js:300:19)
04:21:38 at bootstrapNodeJSCore (internal/bootstrap/node.js:833:3)
04:21:38 ...

[ZauberNerd]

@gireeshpunathil yes, these failures were because of our changes - we used the option fatal: true to trigger the code path that we wanted to test, but did not realize that this option is not available on certain builds.
I have changed the option to ignoreBOM: true (and updated the tests accordingly) and rebased against current master.

Edit: Also, since I rebased and made actual changes to the commit and code, we should invalidate all approvals on this PR?

[gireeshpunathil]

@robin-drexler - thanks. the sanity test failed because:
the first letter of the first word after the subsystem name test: TextDecoder custom inspection should have been small letter, according to the rule!

we can fix it while landing, so no worries.

Also, since I rebased and made actual changes to the commit and code, we should invalidate all approvals on this PR?

@jasnell@addaleax@watilde@cjihrig@BridgeAR PTAL.

CI: https://ci.nodejs.org/job/node-test-pull-request/18569/

[gireeshpunathil]

@robin-drexler - linter failed with:
First word after subsystem(s) in title should be lowercase. title-format

so basically the T in your commit message: test: TextDecoder custom inspection is the culprit. Will you amend the commit message? thanks.

[gireeshpunathil]

CI failure seems to be unrelated, however re-running to be doubles-sure.
Resume CI: https://ci.nodejs.org/job/node-test-commit/23180/

[Trott]

Failure on shared-lib without-intl CI seems related:

https://ci.nodejs.org/job/node-test-commit-linux-containered/8570/nodes=ubuntu1604_sharedlibs_withoutintl_x64/console

04:51:17 not ok 1999 parallel/test-whatwg-encoding-textdecoder04:51:17 ---04:51:17 duration_ms: 0.14204:51:17 severity: fail04:51:17 exitcode: 104:51:17 stack: |-04:51:17 assert.js:8604:51:17 throw new AssertionError(obj);04:51:17 ^04:51:17 04:51:17 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:04:51:17 + actual - expected04:51:17 04:51:17 + "TextDecoder {\n encoding: 'utf-8',\n fatal: false,\n ignoreBOM: true,\n [Symbol(flags)]: 4,\n [Symbol(handle)]:\n StringDecoder {\n encoding: 'utf8',\n [Symbol(kNativeDecoder)]: <Buffer 00 00 00 00 00 00 01> } }"04:51:17 - "TextDecoder {\n encoding: 'utf-8',\n fatal: false,\n ignoreBOM: true,\n [Symbol(flags)]: 4,\n [Symbol(handle)]: {} }"04:51:17 at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_withoutintl_x64/test/parallel/test-whatwg-encoding-textdecoder.js:104:10)04:51:17 at Module._compile (internal/modules/cjs/loader.js:722:30)04:51:17 at Object.Module._extensions..js (internal/modules/cjs/loader.js:733:10)04:51:17 at Module.load (internal/modules/cjs/loader.js:620:32)04:51:17 at tryModuleLoad (internal/modules/cjs/loader.js:560:12)04:51:17 at Function.Module._load (internal/modules/cjs/loader.js:552:3)04:51:17 at Function.Module.runMain (internal/modules/cjs/loader.js:775:12)04:51:17 at startup (internal/bootstrap/node.js:300:19)04:51:17 at bootstrapNodeJSCore (internal/bootstrap/node.js:833:3)04:51:17 ...

[Trott]

Test needs to be fixed...

[Trott]

I'm fixing the test and will try to leave the co-authorship in there, but if our tooling chokes and we can only have one author, is there a clear primary author here?

[robin-drexler]

That'd be @ZauberNerd as I got the sole git attribution for other PR we've paired. @Trott thanks for offering to do the fix, I just wonder if maybe @ZauberNerd would like to do it himself, though. :)

[Trott]

I just wonder if maybe @ZauberNerd would like to do it himself, though. :)

Cool. I'll hold off, especially because I'm not actually sure if the the test is failing because stuff is broken or if the different result should be expected if there is no Intl compiled into the node executable.

(If it helps, please note that common.hasIntl is a thing in our tests!)

[Trott]

@robin-drexler@ZauberNerd Still being worked on? Or should someone else pick this up?

[ZauberNerd]

@Trott I rebased against master, amended the commit message to adhere to the linter rules and added an if/else branch for common.hasIntl to test for both variants.
Let me know if this is fine for you or if the tests should be written differently.
Another approach I thought about would be to just test for the substring that I'm actually interested in.

Edit: The Jenkins jobs have not re-run after this force-push. Do they need to be triggered manually?

[Trott]

The Jenkins jobs have not re-run after this force-push. Do they need to be triggered manually?

Yep!

CI: https://ci.nodejs.org/job/node-test-pull-request/18816/

test fixed

[Trott]

Landed in 57869bf. 🎉 Thanks for the contribution!