Uh oh!
There was an error while loading. Please reload this page.
doc: clarify issues and pull requests guidance - #24316
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Removed the "Managing Issues and Pull Requests" header as "managing" is unclear in this context. Useful information from the section was retained as an introductory paragraph for the "Issues and Pull Requests" section. Vague terminology (e.g., "full responsibility") was removed.
vsemozhetbyt
approved these changes
Nov 12, 2018
starkwang
approved these changes
Nov 12, 2018
cjihrig
approved these changes
Nov 12, 2018
lpinca
approved these changes
Nov 12, 2018
fhinkel
approved these changes
Nov 13, 2018
trivikr
approved these changes
Nov 13, 2018
Trott
commented
Nov 14, 2018
MemberAuthor
Landed in c1d18a0 |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Nov 14, 2018
Removed the "Managing Issues and Pull Requests" header as "managing" is unclear in this context. Useful information from the section was retained as an introductory paragraph for the "Issues and Pull Requests" section. Vague terminology (e.g., "full responsibility") was removed. PR-URL: nodejs#24316 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Nov 14, 2018
Removed the "Managing Issues and Pull Requests" header as "managing" is unclear in this context. Useful information from the section was retained as an introductory paragraph for the "Issues and Pull Requests" section. Vague terminology (e.g., "full responsibility") was removed. PR-URL: #24316 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kiyomizumia pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
Removed the "Managing Issues and Pull Requests" header as "managing" is unclear in this context. Useful information from the section was retained as an introductory paragraph for the "Issues and Pull Requests" section. Vague terminology (e.g., "full responsibility") was removed. PR-URL: nodejs#24316 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Nov 15, 2018
Removed the "Managing Issues and Pull Requests" header as "managing" is unclear in this context. Useful information from the section was retained as an introductory paragraph for the "Issues and Pull Requests" section. Vague terminology (e.g., "full responsibility") was removed. PR-URL: #24316 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Nov 15, 2018
codebytere pushed a commit
that referenced
this pull request
Jan 12, 2019
Removed the "Managing Issues and Pull Requests" header as "managing" is unclear in this context. Useful information from the section was retained as an introductory paragraph for the "Issues and Pull Requests" section. Vague terminology (e.g., "full responsibility") was removed. PR-URL: #24316 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the "Managing Issues and Pull Requests" header as "managing" is
unclear in this context.
Useful information from the section was retained as an introductory
paragraph for the "Issues and Pull Requests" section. Vague terminology
(e.g., "full responsibility") was removed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes