Uh oh!
There was an error while loading. Please reload this page.
build: remove unnecessary prerequisite in Makefile - #24342
Closed
Trott wants to merge 1 commit into
Closed
Conversation
bench-addons-build is not needed by test-ci.
Trott
commented
Nov 13, 2018
MemberAuthor
refack
approved these changes
Nov 13, 2018
lpinca
approved these changes
Nov 13, 2018
Trott
commented
Nov 13, 2018
MemberAuthor
CI again, this time with CERTIFY_SAFE checked. 😅 |
richardlau
approved these changes
Nov 13, 2018
Trott
commented
Nov 15, 2018
MemberAuthor
Landed in 150c9be |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Nov 15, 2018
bench-addons-build is not needed by test-ci. PR-URL: nodejs#24342 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit
that referenced
this pull request
Nov 18, 2018
bench-addons-build is not needed by test-ci. PR-URL: #24342 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
bench-addons-build is not needed by test-ci. PR-URL: #24342 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This was referenced Dec 7, 2018
codebytere pushed a commit
that referenced
this pull request
Jan 12, 2019
bench-addons-build is not needed by test-ci. PR-URL: #24342 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Jan 29, 2019
bench-addons-build is not needed by test-ci. PR-URL: #24342 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bench-addons-build is not needed by test-ci.
@nodejs/build-files
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes