Skip to content

src: remove unused variables - #24355

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:unused_vars
Closed

src: remove unused variables#24355
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:unused_vars

Conversation

@danbev

@danbevdanbev commented Nov 14, 2018

Copy link
Copy Markdown
Contributor

Currently the following compiler warnings are generated:

../src/node_process.cc:799:16:warning: unused variable 'ary' [-Wunused-variable] Local<Array> ary = Array::New(args.GetIsolate()); ^1 warning generated.
../src/node_http2.cc:1294:16:warning: unused variable 'holder' [-Wunused-variable] Local<Array> holder = Array::New(isolate); ^1 warning generated.

This commit removes these unused variables.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
src: remove unused variables
84a7ae2
Currently the following compiler warnings are generated:
../src/node_process.cc:799:16:
warning: unused variable 'ary' [-Wunused-variable]
Local<Array> ary = Array::New(args.GetIsolate());
^
1 warning generated.
../src/node_http2.cc:1294:16:
warning: unused variable 'holder' [-Wunused-variable]
Local<Array> holder = Array::New(isolate);
^
1 warning generated.
This commit removes these unused variables.
@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2018

Copy link
Copy Markdown
Collaborator

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1603/pipeline

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Nov 14, 2018
@danbev

danbev commented Nov 14, 2018

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/18599/

mhdawson
mhdawson approved these changes Nov 14, 2018
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

addaleax pushed a commit that referenced this pull request Nov 16, 2018
@danbev@addaleax
src: remove unused variables
39a5e7d
Currently the following compiler warnings are generated:
../src/node_process.cc:799:16:
warning: unused variable 'ary' [-Wunused-variable]
Local<Array> ary = Array::New(args.GetIsolate());
^
1 warning generated.
../src/node_http2.cc:1294:16:
warning: unused variable 'holder' [-Wunused-variable]
Local<Array> holder = Array::New(isolate);
^
1 warning generated.
This commit removes these unused variables.
PR-URL: #24355
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott

Trott commented Nov 17, 2018

Copy link
Copy Markdown
Member

Looks like @addaleax landed this in commit 39a5e7d.

@TrottTrott closed this Nov 17, 2018
targos pushed a commit that referenced this pull request Nov 18, 2018
@danbev@targos
src: remove unused variables
27cc3ad
Currently the following compiler warnings are generated:
../src/node_process.cc:799:16:
warning: unused variable 'ary' [-Wunused-variable]
Local<Array> ary = Array::New(args.GetIsolate());
^
1 warning generated.
../src/node_http2.cc:1294:16:
warning: unused variable 'holder' [-Wunused-variable]
Local<Array> holder = Array::New(isolate);
^
1 warning generated.
This commit removes these unused variables.
PR-URL: #24355
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@danbev@rvagg
src: remove unused variables
806570d
Currently the following compiler warnings are generated:
../src/node_process.cc:799:16:
warning: unused variable 'ary' [-Wunused-variable]
Local<Array> ary = Array::New(args.GetIsolate());
^
1 warning generated.
../src/node_http2.cc:1294:16:
warning: unused variable 'holder' [-Wunused-variable]
Local<Array> holder = Array::New(isolate);
^
1 warning generated.
This commit removes these unused variables.
PR-URL: #24355
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@danbev
danbev deleted the unused_vars branch December 4, 2018 04:25
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@danbev@nodejs-github-bot@Trott@lpinca@targos@cjihrig@BridgeAR@mhdawson@codebytere