Skip to content

test: remove unused function arguments in async-hooks tests - #24368

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:async-hooks-unused
Closed

test: remove unused function arguments in async-hooks tests#24368
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:async-hooks-unused

Conversation

@Trott

@TrottTrott commented Nov 14, 2018

Copy link
Copy Markdown
Member

Remove unused function arguments in two async-hooks tests.

(This actually started as a bigger change but then I realized the bigger change was wrong. Oops.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: remove unused function arguments in async-hooks tests
291ac64
Remove unused function arguments in two async-hooks tests.
@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1616/pipeline

@nodejs-github-botnodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Nov 14, 2018
@Trott

Trott commented Nov 14, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/18617/

@Trott

Trott commented Nov 14, 2018

Copy link
Copy Markdown
MemberAuthor

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18618/

mhdawson
mhdawson approved these changes Nov 14, 2018
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott

Trott commented Nov 14, 2018

Copy link
Copy Markdown
MemberAuthor

Took problematic host offline. Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18620/

@Trott

Trott commented Nov 16, 2018

Copy link
Copy Markdown
MemberAuthor

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18668/

@Trott

Trott commented Nov 16, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in b7e9804

@TrottTrott closed this Nov 16, 2018
Trott added a commit to Trott/io.js that referenced this pull request Nov 16, 2018
@Trott
test: remove unused function arguments in async-hooks tests
b7e9804
Remove unused function arguments in two async-hooks tests.
PR-URL: nodejs#24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos pushed a commit that referenced this pull request Nov 18, 2018
@Trott@targos
test: remove unused function arguments in async-hooks tests
3682561
Remove unused function arguments in two async-hooks tests.
PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Trott@rvagg
test: remove unused function arguments in async-hooks tests
ee64ae0
Remove unused function arguments in two async-hooks tests.
PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@Trott@codebytere
test: remove unused function arguments in async-hooks tests
979ea16
Remove unused function arguments in two async-hooks tests.
PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@codebyterecodebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@Trott@codebytere
test: remove unused function arguments in async-hooks tests
987df27
Remove unused function arguments in two async-hooks tests.
PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@Trott
Trott deleted the async-hooks-unused branch January 13, 2022 22:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkelfhinkelfhinkel approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooksIssues and PRs related to the async hooks subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@nodejs-github-bot@fhinkel@addaleax@lpinca@mhdawson