Skip to content

doc: add help on fixing IPv6 test failures - #24372

Closed
mhdawson wants to merge 7 commits into
nodejs:masterfrom
mhdawson:building-ipv6
Closed

doc: add help on fixing IPv6 test failures#24372
mhdawson wants to merge 7 commits into
nodejs:masterfrom
mhdawson:building-ipv6

Conversation

@mhdawson

@mhdawsonmhdawson commented Nov 14, 2018

Copy link
Copy Markdown
Member

It took me a while to figure out the problem and
then some googling to find the right answer. I think
it is worth adding this to help other people in the
future and to have an easy place to point people to
for the solution if their test run fails with IPv6
failures.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@mhdawson
doc: add help on fixing IPv6 test failures
db56b46
It took me a while to figure out the problem and
then some googling to find the right answer. I think
it is worth adding this to help other people in the
future and to have an easy place to point people to
for the solution if their test run fails with IPv6
failures.
@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2018

Copy link
Copy Markdown
Collaborator

@mhdawson build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1618/pipeline

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 14, 2018
vsemozhetbyt
vsemozhetbyt reviewed Nov 14, 2018
View reviewed changes
Comment threadBUILDING.md Outdated
Comment threadBUILDING.md Outdated
Comment threadBUILDING.md Outdated
vsemozhetbytand others added 3 commits November 15, 2018 09:19
@vsemozhetbyt@mhdawson
squash: accept suggestion
60caa23
Co-Authored-By: mhdawson <michael_dawson@ca.ibm.com>
@vsemozhetbyt@mhdawson
squash: accept suggestion
5fe1c41
Co-Authored-By: mhdawson <michael_dawson@ca.ibm.com>
@vsemozhetbyt@mhdawson
squash: accept suggestion
45d4a58
Co-Authored-By: mhdawson <michael_dawson@ca.ibm.com>
@mhdawson

mhdawson commented Nov 15, 2018

Copy link
Copy Markdown
MemberAuthor

@vsemozhetbyt thanks for the review, accepted all of your suggestions.

thefourtheye
thefourtheye approved these changes Nov 15, 2018
View reviewed changes
Comment threadBUILDING.md Outdated
on Ubuntu that does not seem to be the case. '::1' can be enabled on the
loopback interface on Ubuntu using:

`sudo sysctl -w net.ipv6.conf.lo.disable_ipv6=0`

@thefourtheyethefourtheyeNov 15, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It would be better if we formatted this as console text, instead of inline code.

@mhdawsonmhdawsonNov 15, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mhdawson

mhdawson commented Nov 15, 2018

Copy link
Copy Markdown
MemberAuthor

@vsemozhetbyt any chance you can add your approval as well?

Trott
Trott reviewed Nov 16, 2018
View reviewed changes
Comment threadBUILDING.md Outdated
Trott
Trott reviewed Nov 16, 2018
View reviewed changes
Comment threadBUILDING.md Outdated
The tests attempt to detect support for IPv6 and exclude IPv6 tests if
appropriate. However, if your main interface has IPv6 addresses then your
loopback interface must also have '::1' enabled. For some default installations
on Ubuntu that does not seem to be the case. '::1' can be enabled on the

@TrottTrottNov 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on Ubuntu that does not seem to be the case. '::1' can be enabled on the
on Ubuntu, that does not seem to be the case. '::1' can be enabled on the

Trott
Trott reviewed Nov 16, 2018
View reviewed changes
Comment threadBUILDING.md Outdated
appropriate. However, if your main interface has IPv6 addresses then your
loopback interface must also have '::1' enabled. For some default installations
on Ubuntu that does not seem to be the case. '::1' can be enabled on the
loopback interface on Ubuntu using:

@TrottTrottNov 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the last sentence with this?

To enable '::1' on the loopback interface on Ubuntu:

@fhinkelfhinkelNov 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or at least

You can enable...

@mhdawsonmhdawsonNov 16, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure I had something like "You can .." but guidance is not to use you. :)

fhinkel
fhinkel approved these changes Nov 16, 2018
View reviewed changes
Comment threadBUILDING.md Outdated
appropriate. However, if your main interface has IPv6 addresses then your
loopback interface must also have '::1' enabled. For some default installations
on Ubuntu that does not seem to be the case. '::1' can be enabled on the
loopback interface on Ubuntu using:

@fhinkelfhinkelNov 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or at least

You can enable...

Trottand others added 2 commits November 16, 2018 09:19
@Trott@mhdawson
squash: address changes
e51ba22
Co-Authored-By: mhdawson <michael_dawson@ca.ibm.com>
@mhdawson
squash: address comments
0aaae27
@mhdawson

mhdawson commented Nov 16, 2018

Copy link
Copy Markdown
MemberAuthor

Comments addressed. Like CI run: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1632/

@mhdawson

mhdawson commented Nov 16, 2018

Copy link
Copy Markdown
MemberAuthor

CI good landing.

@mhdawson

mhdawson commented Nov 16, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Landed as 6b4e413

mhdawson added a commit that referenced this pull request Nov 16, 2018
@mhdawson
doc: add help on fixing IPv6 test failures
6b4e413
It took me a while to figure out the problem and
then some googling to find the right answer. I think
it is worth adding this to help other people in the
future and to have an easy place to point people to
for the solution if their test run fails with IPv6
failures.
PR-URL: #24372
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos pushed a commit that referenced this pull request Nov 18, 2018
@mhdawson@targos
doc: add help on fixing IPv6 test failures
60aebd8
It took me a while to figure out the problem and
then some googling to find the right answer. I think
it is worth adding this to help other people in the
future and to have an easy place to point people to
for the solution if their test run fails with IPv6
failures.
PR-URL: #24372
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@mhdawson@rvagg
doc: add help on fixing IPv6 test failures
5f747f1
It took me a while to figure out the problem and
then some googling to find the right answer. I think
it is worth adding this to help other people in the
future and to have an easy place to point people to
for the solution if their test run fails with IPv6
failures.
PR-URL: #24372
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
This was referenced Dec 8, 2018
Closed
Closed
@mhdawson
mhdawson deleted the building-ipv6 branch September 30, 2019 13:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott left review comments
@fhinkelfhinkelfhinkel approved these changes
@lpincalpincalpinca approved these changes
+2 more reviewers
@vsemozhetbytvsemozhetbytvsemozhetbyt left review comments
@thefourtheyethefourtheyethefourtheye approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mhdawson@nodejs-github-bot@fhinkel@thefourtheye@Trott@lpinca@vsemozhetbyt@codebytere