doc: Update collaborator guide with LTS labels by cfanoulis · Pull Request #24379 · nodejs/node

cfanoulis · 2018-11-15T12:53:37Z

This is a copy/extension of PR #24369, I had to redo it because the commit history in my fork was broken

Checklist

documentation is changed or added
commit message follows commit guidelines

cfanoulis · 2018-11-15T12:56:01Z

commit broke again, fixing now

mscdex · 2018-11-15T13:59:25Z

- in a future v6.x release
-* `land-on-v4.x` - tells the release team that the commit should be landed
- in a future v4.x release
+ in a future v6.x release


minor nit: there's an extra space added in the indentation here

mscdex · 2018-11-15T14:00:23Z

+* `land-on-v10.x` - tells the release team that the commit should be landed
+ in a future v6.x release
+* `land-on-v10.x` - tells the release team that the commit should be landed
+ in a future v6.x release


Copy-paste error?

Trott · 2018-11-15T14:06:29Z

+* `land-on-v10.x` - tells the release team that the commit should be landed
+ in a future v6.x release
+* `land-on-v10.x` - tells the release team that the commit should be landed
+ in a future v6.x release


Suggested change
in a future v6.x release
in a future v10.x release

Trott · 2018-11-15T14:07:08Z

- in a future v6.x release
-* `land-on-v4.x` - tells the release team that the commit should be landed
- in a future v4.x release
+ in a future v6.x release


Suggested change
in a future v6.x release
in a future v6.x release

targos · 2018-11-15T15:22:52Z

+ considered for landing in the `v6.x-staging` branch.
+* `land-on-v10.x` - tells the release team that the commit should be landed
+ in a future v6.x release
+* `land-on-v10.x` - tells the release team that the commit should be landed


Suggested change
*`land-on-v10.x` - tells the release team that the commit should be landed
*`land-on-v8.x` - tells the release team that the commit should be landed

targos · 2018-11-15T15:23:03Z

+* `lts-watch-v6.x` - tells the LTS WG that the issue/PR needs to be
+ considered for landing in the `v6.x-staging` branch.
+* `land-on-v10.x` - tells the release team that the commit should be landed
+ in a future v6.x release


Suggested change
in a future v6.x release
in a future v10.x release

targos · 2018-11-15T15:23:12Z

+* `land-on-v10.x` - tells the release team that the commit should be landed
+ in a future v6.x release
+* `land-on-v10.x` - tells the release team that the commit should be landed
+ in a future v6.x release


Suggested change
in a future v6.x release
in a future v8.x release

cfanoulis · 2018-11-15T16:35:29Z

yep, cp broke, will be fixing

cfanoulis · 2018-11-15T16:42:21Z

all requested changes should have been addresed with the above commits, let me know if there is anything more

vsemozhetbyt

With consistency nits)

vsemozhetbyt · 2018-11-15T20:03:44Z

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1623/

vsemozhetbyt · 2018-11-15T20:03:53Z

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

Trott · 2018-11-16T00:08:23Z

Landed in ef3691a.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

PR-URL: nodejs#24379 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #24379 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 15, 2018

doc: update collaborator guide with LTS labels
c13f759

mscdex reviewed Nov 15, 2018
View reviewed changes

Trott reviewed Nov 15, 2018
View reviewed changes

targos reviewed Nov 15, 2018
View reviewed changes

cfanoulis added 2 commits November 15, 2018 18:40

doc: fix indenttation in the collab. guide
837b312

doc: fix incorrect numbering in labels
88c3bb4

richardlau approved these changes Nov 15, 2018
View reviewed changes

vsemozhetbyt approved these changes Nov 15, 2018
View reviewed changes

Comment threadCOLLABORATOR_GUIDE.md Outdated
Comment threadCOLLABORATOR_GUIDE.md Outdated
Comment threadCOLLABORATOR_GUIDE.md Outdated

doc: fix punctuation
b0a38cc

lpinca approved these changes Nov 15, 2018
View reviewed changes

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 16, 2018

Trott closed this Nov 16, 2018

targos pushed a commit that referenced this pull request Nov 18, 2018
doc: update collaborator guide with LTS labels
eb178bb
PR-URL: #24379 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

rvagg pushed a commit that referenced this pull request Nov 28, 2018
doc: update collaborator guide with LTS labels
85f9201
PR-URL: #24379 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks

This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed

This was referenced Dec 8, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed

codebytere pushed a commit that referenced this pull request Jan 12, 2019
doc: update collaborator guide with LTS labels
37c9a83
PR-URL: #24379 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

codebytere mentioned this pull request Jan 15, 2019
v10.15.1 proposal #25346
Merged

codebytere pushed a commit that referenced this pull request Jan 29, 2019
doc: update collaborator guide with LTS labels
ae3a194
PR-URL: #24379 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

	*`land-on-v10.x` - tells the release team that the commit should be landed
	*`land-on-v8.x` - tells the release team that the commit should be landed

Uh oh!

Uh oh!

Conversation

cfanoulis commented Nov 15, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

cfanoulis commented Nov 15, 2018

Uh oh!

mscdexNov 15, 2018

Choose a reason for hiding this comment

Uh oh!

mscdexNov 15, 2018

Choose a reason for hiding this comment

Uh oh!

TrottNov 15, 2018

Choose a reason for hiding this comment

Uh oh!

TrottNov 15, 2018

Choose a reason for hiding this comment

Uh oh!

targosNov 15, 2018

Choose a reason for hiding this comment

Uh oh!

targosNov 15, 2018

Choose a reason for hiding this comment

Uh oh!

targosNov 15, 2018

Choose a reason for hiding this comment

Uh oh!

cfanoulis commented Nov 15, 2018

Uh oh!

cfanoulis commented Nov 15, 2018

Uh oh!

vsemozhetbyt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vsemozhetbyt commented Nov 15, 2018

Uh oh!

vsemozhetbyt commented Nov 15, 2018

Uh oh!

Trott commented Nov 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cfanoulis commented Nov 15, 2018•
edited
Loading

vsemozhetbyt left a comment •
edited
Loading