Uh oh!
There was an error while loading. Please reload this page.
tools: update to remark-lint-preset-node@1.2.0 - #24391
Closed
Trott wants to merge 2 commits into
Closed
Conversation
Minor formatting adjustments to two changelog files in preparation for a markdown lint rule.
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.)
Trott
commented
Nov 18, 2018
MemberAuthor
@nodejs/linting @nodejs/documentation This can use some reviews. |
jasnell
approved these changes
Nov 19, 2018
watilde
approved these changes
Nov 19, 2018
Trott
commented
Nov 19, 2018
MemberAuthor
Landed in dafd76c...3cac82f |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Nov 19, 2018
Minor formatting adjustments to two changelog files in preparation for a markdown lint rule. PR-URL: nodejs#24391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Trott added a commit
to Trott/io.js
that referenced
this pull request
Nov 19, 2018
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.) PR-URL: nodejs#24391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 19, 2018
Minor formatting adjustments to two changelog files in preparation for a markdown lint rule. PR-URL: #24391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 19, 2018
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.) PR-URL: #24391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
Minor formatting adjustments to two changelog files in preparation for a markdown lint rule. PR-URL: #24391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.) PR-URL: #24391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This was referenced Dec 7, 2018
codebytere pushed a commit
that referenced
this pull request
Jan 13, 2019
Minor formatting adjustments to two changelog files in preparation for a markdown lint rule. PR-URL: #24391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
codebytere pushed a commit
that referenced
this pull request
Jan 13, 2019
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.) PR-URL: #24391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Minor formatting adjustments to two changelog files in preparation for a markdown lint rule. PR-URL: nodejs#24391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.) PR-URL: nodejs#24391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Jan 29, 2019
Minor formatting adjustments to two changelog files in preparation for a markdown lint rule. PR-URL: #24391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
codebytere pushed a commit
that referenced
this pull request
Jan 29, 2019
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.) PR-URL: #24391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.)
Minor formatting adjustments to two changelog files in preparation for the new markdown lint rule.
make -j4 test(UNIX), orvcbuild test(Windows) passes