Skip to content

doc: update 11.0.0 changelog with missing commit - #24404

Closed
Trott wants to merge 3 commits into
nodejs:masterfrom
Trott:changelog-fix
Closed

doc: update 11.0.0 changelog with missing commit#24404
Trott wants to merge 3 commits into
nodejs:masterfrom
Trott:changelog-fix

Conversation

@Trott

Copy link
Copy Markdown
Member

Fixes: #23846

Please 👍 here to fast-track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@TrottTrott added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 16, 2018
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@TrottTrott closed this Nov 16, 2018
@refackrefack removed the fast-track PRs that do not need to wait for 48 hours to land. label Nov 16, 2018
@TrottTrott reopened this Nov 16, 2018
@Trott

Copy link
Copy Markdown
MemberAuthor

So, this is a little strange in that the commit is manually inserted into the 11.0.0 semver-major list even though it was introduced (by accidentally overlooking the semver-ness) in 10.x, where it was subsequently reverted. But we still want to note it in 11.0.0. So, although there may be a better way to do it, I've inserted it into the normal flow. That has to be better than omitting it at least, right?

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 16, 2018
@Trott

Copy link
Copy Markdown
MemberAuthor

@refack

Copy link
Copy Markdown
Contributor

That has to be better than omitting it at least, right?

The remaining issue is that it's not in the blog post, and our detailed semver major changes list, and recommended workarounds.

@Trott

Copy link
Copy Markdown
MemberAuthor

The remaining issue is that it's not in the blog post,

nodejs/nodejs.org#1900

@danbev

Copy link
Copy Markdown
Contributor

Landed in b32c5f0.

@danbevdanbev closed this Nov 20, 2018
danbev pushed a commit that referenced this pull request Nov 20, 2018
PR-URL: #24404Fixes: #23846
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos pushed a commit that referenced this pull request Nov 20, 2018
PR-URL: #24404Fixes: #23846
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
PR-URL: #24404Fixes: #23846
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
4 tasks
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24404Fixes: nodejs#23846
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@Trott
Trott deleted the changelog-fix branch January 13, 2022 22:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing semver-major change in v11.0.0 changelog

5 participants

@Trott@nodejs-github-bot@refack@danbev@targos