Skip to content

replace anonymous closure for test-http-expect-handling.js - #24423

Closed
Jayasankar-m wants to merge 1 commit into
nodejs:masterfrom
Jayasankar-m:jsnew
Closed

replace anonymous closure for test-http-expect-handling.js#24423
Jayasankar-m wants to merge 1 commit into
nodejs:masterfrom
Jayasankar-m:jsnew

Conversation

@Jayasankar-m

@Jayasankar-mJayasankar-m commented Nov 17, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2018
@gireeshpunathilgireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
targos
targos approved these changes Nov 17, 2018
View reviewed changes

@targostargos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Commit message should start with test: replace ...

@targos

targos commented Nov 17, 2018

Copy link
Copy Markdown
Member

👍 to fast-track

@targostargos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 17, 2018
@gireeshpunathil

gireeshpunathil commented Nov 18, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18711/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 18, 2018
@Trott

Trott commented Nov 18, 2018

Copy link
Copy Markdown
Member

Landed in 1dadaf9

@TrottTrott closed this Nov 18, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 18, 2018
@Jayasankar-m@Trott
test:replace anonymous closure for test-http-expect-handling.js
1dadaf9
PR-URL: nodejs#24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 18, 2018
@Jayasankar-m@targos
test:replace anonymous closure for test-http-expect-handling.js
e9fb811
PR-URL: #24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos

targos commented Nov 18, 2018

Copy link
Copy Markdown
Member

@Trott did core-validate-commit accept the message? I'm asking because there should be a space after the colon.

@richardlau

richardlau commented Nov 18, 2018

Copy link
Copy Markdown
Member

@Trott did core-validate-commit accept the message? I'm asking because there should be a space after the colon.

Apparently it did:

https://travis-ci.com/nodejs/node/jobs/159274629#L695-L703

test:replace anonymous closure for test-http-expect-handling.js
+npx -q core-validate-commit --no-validate-metadata https://api.github.com/repos/nodejs/node/commits/c792fb7a10120092bfb3847d76d7691490152226
✔ c792fb7a10120092bfb3847d76d7691490152226
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
⚠ 0:50 Title should be <= 50 columns. title-length

@targos

targos commented Nov 18, 2018

Copy link
Copy Markdown
Member

nodejs/core-validate-commit#35

rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Jayasankar-m@rvagg
test:replace anonymous closure for test-http-expect-handling.js
ffb5e5d
PR-URL: #24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@Jayasankar-m@codebytere
test:replace anonymous closure for test-http-expect-handling.js
e868fdd
PR-URL: #24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Jayasankar-m@refack
test:replace anonymous closure for test-http-expect-handling.js
53be6ca
PR-URL: nodejs#24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebyterecodebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@Jayasankar-m@codebytere
test:replace anonymous closure for test-http-expect-handling.js
f4c2d9e
PR-URL: #24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@beevelopbeevelop mentioned this pull request Jan 29, 2019
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Jayasankar-m@targos@gireeshpunathil@Trott@richardlau@trivikr@nodejs-github-bot