Skip to content

test: change anonymous closure function to arrow function - #24433

Closed
nethraravindran wants to merge 1 commit into
nodejs:masterfrom
nethraravindran:anonymous-arrow1
Closed

test: change anonymous closure function to arrow function#24433
nethraravindran wants to merge 1 commit into
nodejs:masterfrom
nethraravindran:anonymous-arrow1

Conversation

@nethraravindran

@nethraravindrannethraravindran commented Nov 17, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2018
@gireeshpunathilgireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
@targos

targos commented Nov 17, 2018

Copy link
Copy Markdown
Member

👍 to fast-track

@targostargos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 17, 2018
@richardlau

richardlau commented Nov 17, 2018

Copy link
Copy Markdown
Member

This appears to make the test fail:

https://travis-ci.com/nodejs/node/jobs/159275096#L9045-L9062

=== release test-net-connect-options-port ===
Path: parallel/test-net-connect-options-port
/home/travis/build/nodejs/node/test/parallel/test-net-connect-options-port.js:87
const port = this.address().port;
^
TypeError: this.address is not a function
at Server.server.listen.common.mustCall (/home/travis/build/nodejs/node/test/parallel/test-net-connect-options-port.js:87:23)
at Server.<anonymous> (/home/travis/build/nodejs/node/test/common/index.js:346:15)
at Object.onceWrapper (events.js:273:13)
at Server.emit (events.js:182:13)
at emitListeningNT (net.js:1320:10)
at process.internalTickCallback (internal/process/next_tick.js:72:19)
Command: out/Release/node /home/travis/build/nodejs/node/test/parallel/test-net-connect-options-port.js
[06:06|% 100|+ 2430|- 1]: Done

gireeshpunathil
gireeshpunathil reviewed Nov 18, 2018
View reviewed changes
Comment threadtest/parallel/test-net-connect-options-port.js Outdated
@TrottTrott removed the fast-track PRs that do not need to wait for 48 hours to land. label Nov 18, 2018
trivikr
trivikr previously requested changes Nov 19, 2018
View reviewed changes

@trivikrtrivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly mentioning Request changes

Comment threadtest/parallel/test-net-connect-options-port.js Outdated
@gireeshpunathil

gireeshpunathil commented Nov 22, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18885/

@Trott

Trott commented Nov 22, 2018

Copy link
Copy Markdown
Member

@trivikr Change was made and test passes. LGTY?

@addaleax

addaleax commented Nov 23, 2018

Copy link
Copy Markdown
Member

Landed in 9eab803

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

pullBot pushed a commit to Rachelmorrell/node that referenced this pull request Nov 23, 2018
@nethraravindran@addaleax
test: change anonymous closure function to arrow function
9eab803
PR-URL: nodejs#24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Nov 24, 2018
@nethraravindran@targos
test: change anonymous closure function to arrow function
d96978c
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@nethraravindran@rvagg
test: change anonymous closure function to arrow function
9bf2659
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@nethraravindran@codebytere
test: change anonymous closure function to arrow function
f497e91
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@nethraravindran@refack
test: change anonymous closure function to arrow function
f06b29d
PR-URL: nodejs#24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@codebyterecodebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@nethraravindran@codebytere
test: change anonymous closure function to arrow function
1f079e8
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@nethraravindran@codebytere
test: change anonymous closure function to arrow function
6b3b769
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@trivikrtrivikrtrivikr left review comments
+1 more reviewer
@sagirksagirksagirk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@nethraravindran@targos@richardlau@gireeshpunathil@Trott@addaleax@jasnell@cjihrig@sagirk@trivikr@nodejs-github-bot