Uh oh!
There was an error while loading. Please reload this page.
test: Using arrow functions - #24436
Closed
NoSkillGirl wants to merge 1 commit into
Closed
Conversation
targos
reviewed
Nov 17, 2018
targos
left a comment
Member
There was a problem hiding this comment.
Commit message should look like test: use arrow functions
Member
There was a problem hiding this comment.
Suggested change
| constserver=tls.Server(options,common.mustCall(socket=>socket.end('Goodbye'),2)); | |
| constserver=tls.Server(options,common.mustCall(socket=>socket.end('Goodbye'),2)); |
NoSkillGirlforce-pushed
the
testcase-arrowfunctions
branch
from
November 20, 2018 23:55
0ee9e42 to
75cf1d4CompareNoSkillGirlforce-pushed
the
testcase-arrowfunctions
branch
from
November 21, 2018 00:02
75cf1d4 to
362b69dCompareNoSkillGirlforce-pushed
the
testcase-arrowfunctions
branch
from
November 21, 2018 02:15
0d6b3c8 to
272d172CompareNoSkillGirlforce-pushed
the
testcase-arrowfunctions
branch
from
November 21, 2018 06:48
272d172 to
e12f560Comparegireeshpunathil
commented
Nov 21, 2018
Member
ping @NoSkillGirl |
NoSkillGirlforce-pushed
the
testcase-arrowfunctions
branch
from
November 21, 2018 15:28
e12f560 to
0dbe2f8CompareNoSkillGirl
commented
Nov 21, 2018
ContributorAuthor
Pong @gireeshpunathil |
gireeshpunathil
approved these changes
Nov 21, 2018
- Using arrow functions in test-tls-client-resume.js - Fixed error, Expected parentheses around arrow function argument arrow-parens PR-URL: nodejs#24436
NoSkillGirlforce-pushed
the
testcase-arrowfunctions
branch
from
November 21, 2018 16:22
0dbe2f8 to
d91a981Comparejasnell
approved these changes
Nov 21, 2018
Contributor
Updated CI: https://ci.nodejs.org/job/node-test-pull-request/18866/ ✔️ |
danbev
commented
Nov 22, 2018
Contributor
Landed in 282e533. 🎉 |
danbev pushed a commit
that referenced
this pull request
Nov 22, 2018
- Using arrow functions in test-tls-client-resume.js - Fixed error, Expected parentheses around arrow function argument arrow-parens PR-URL: #24436 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
NoSkillGirl
commented
Nov 22, 2018
ContributorAuthor
Thank You @danbev |
targos pushed a commit
that referenced
this pull request
Nov 24, 2018
- Using arrow functions in test-tls-client-resume.js - Fixed error, Expected parentheses around arrow function argument arrow-parens PR-URL: #24436 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
- Using arrow functions in test-tls-client-resume.js - Fixed error, Expected parentheses around arrow function argument arrow-parens PR-URL: #24436 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 8, 2018
codebytere pushed a commit
that referenced
this pull request
Jan 13, 2019
- Using arrow functions in test-tls-client-resume.js - Fixed error, Expected parentheses around arrow function argument arrow-parens PR-URL: #24436 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
- Using arrow functions in test-tls-client-resume.js - Fixed error, Expected parentheses around arrow function argument arrow-parens PR-URL: nodejs#24436 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Jan 29, 2019
- Using arrow functions in test-tls-client-resume.js - Fixed error, Expected parentheses around arrow function argument arrow-parens PR-URL: #24436 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit
that referenced
this pull request
Jan 29, 2019
- Using arrow functions in test-tls-client-resume.js - Fixed error, Expected parentheses around arrow function argument arrow-parens PR-URL: #24436 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using arrow functions in test-tls-client-resume.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes