Uh oh!
There was an error while loading. Please reload this page.
test: refactor test-http-write-empty-string to use arrow functions - #24483
Closed
sagirk wants to merge 3 commits into
Closed
test: refactor test-http-write-empty-string to use arrow functions#24483sagirk wants to merge 3 commits into
sagirk wants to merge 3 commits into
Conversation
In `test/parallel/test-http-write-empty-string.js`, callbacks use anonymous closure functions. It is safe to replace them with arrow functions since these callbacks don't contain references to `this`, `super` or `arguments`. This results in shorter functions.
Uh oh!
There was an error while loading. Please reload this page.
In `test/parallel/test-http-write-empty-string.js`, the callback passed to `http.createServer` contains a reference to `this`. Since the object referenced by `this` doesn't pre-exist, revert the arrow function to an anonymous closure function as a callback. Similarly, the callback passed to `server.listen` too contains a reference to `this`. However, in this case, `this` resolves to a pre-existing object `server`. Therefore, it is safe to use an arrow function as a callback as long as `this` is replaced with `server`.
Fix ESLint complaint: "28:42 Unexpected space before function parentheses space-before-function-paren".
gireeshpunathil
approved these changes
Nov 20, 2018
gireeshpunathil
commented
Nov 20, 2018
Member
BridgeAR
approved these changes
Nov 20, 2018
Trott
commented
Nov 21, 2018
Member
👍 here to fast-track. |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 21, 2018
In `test/parallel/test-http-write-empty-string.js`, callbacks use anonymous closure functions. Replace them with arrow functions. PR-URL: nodejs#24483 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott
commented
Nov 21, 2018
Member
Landed in e610685 |
targos pushed a commit
that referenced
this pull request
Nov 21, 2018
In `test/parallel/test-http-write-empty-string.js`, callbacks use anonymous closure functions. Replace them with arrow functions. PR-URL: #24483 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
In `test/parallel/test-http-write-empty-string.js`, callbacks use anonymous closure functions. Replace them with arrow functions. PR-URL: #24483 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Dec 7, 2018
codebytere pushed a commit
that referenced
this pull request
Jan 13, 2019
In `test/parallel/test-http-write-empty-string.js`, callbacks use anonymous closure functions. Replace them with arrow functions. PR-URL: #24483 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
In `test/parallel/test-http-write-empty-string.js`, callbacks use anonymous closure functions. Replace them with arrow functions. PR-URL: nodejs#24483 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
codebytere pushed a commit
that referenced
this pull request
Jan 29, 2019
In `test/parallel/test-http-write-empty-string.js`, callbacks use anonymous closure functions. Replace them with arrow functions. PR-URL: #24483 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
test/parallel/test-http-write-empty-string.js, callbacks useanonymous closure functions. It is safe to replace them with arrow
functions since these callbacks don't contain references to
this,superorarguments. This results in shorter functions.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes