Uh oh!
There was an error while loading. Please reload this page.
build,src: sync /src/ files with node.gyp - #24505
Merged
Merged
Conversation
nodejs-github-bot
commented
Nov 20, 2018
Collaborator
@refack sadly an error occured when I tried to trigger a build :( |
refack
commented
Nov 20, 2018
ContributorAuthor
refack
commented
Nov 26, 2018
ContributorAuthor
/CC @nodejs/build-files |
richardlau
approved these changes
Nov 26, 2018
Trott
commented
Nov 26, 2018
Member
A second review on this one would be nice. /ping @danbev@addaleax@bnoordhuis@indutny@jasnell |
danbev
approved these changes
Nov 26, 2018
indutny
approved these changes
Nov 26, 2018
| 'src/node_crypto_bio.h', | ||
| 'src/node_crypto_clienthello.h', | ||
| 'src/node_crypto_clienthello-inl.h', | ||
| 'src/node_crypto_groups.h', |
Member
There was a problem hiding this comment.
Are headers really necessary here at all?
ContributorAuthor
There was a problem hiding this comment.
Sort of... they are added as dependencies for MSBuild and ninja. Also they are added to the MSVS GUI + intellisense + static analysis.
ContributorAuthor
There was a problem hiding this comment.
Maybe also relevant for XCode, and compile_commands.json
PR-URL: nodejs#24505 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 27, 2018
PR-URL: #24505 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24505 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
This was referenced Dec 7, 2018
refack added a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24505 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing files. Sort
.cppand.hblocks.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes