Uh oh!
There was an error while loading. Please reload this page.
tools: update remark-preset-lint-node to v1.3.1 - #24642
Conversation
Trott
commented
Nov 25, 2018
There are two .md files with trailing spaces that will need to be fixed before this lands. One is the README and the other is a CHANGELOG file if I recall correctly. |
Trott
commented
Nov 25, 2018
(The fix for the trailing spaces can happen in this PR itself. Probably best as a first commit and then the update of the presets as a second commit.) |
watilde
commented
Nov 25, 2018
I agree. Will arrange the commits and let me ping you when it's done. |
refack
commented
Nov 25, 2018
ATM the linter complains only about |
892664d to
6b19147Comparewatilde
commented
Nov 26, 2018
I removed trailing whitespace in readme and ci gets green🥗 @Trott |
Trott
commented
Nov 26, 2018
Can you re-arrange the commits so that the doc change is first and the update to the plugin is second? (Or squash them into a single commit, although I prefer them separate for ease of backporting.) The way it is now, |
watilde
commented
Nov 26, 2018
This is what I did already :)
|
Trott
commented
Nov 28, 2018
I am easily confused, apparently. :-D |
Trott
commented
Nov 28, 2018
Trott
commented
Nov 28, 2018
Landed in f351c5d...8ce0d4f |
PR-URL: nodejs#24642 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#24642 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#24642 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#24642 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#24642 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#24642 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Summary
remark-lint-no-blockquote-without-markerby @Trott and @watildeChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes