lib: fix worker threads can't read stdout

[leeight]

Fix: #24636

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[leeight]

/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:145
if (err) throw err
^
Error: Invalid api format
at new Parser (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/node_modules/gitlint-parser-base/index.js:23:15)
at new Parser (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/node_modules/gitlint-parser-node/index.js:15:5)
at ValidateCommit.lint (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/lib/index.js:49:22)
at load (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:146:9)
at IncomingMessage.res.on (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:77:9)
at IncomingMessage.emit (events.js:187:15)
at endReadableNT (_stream_readable.js:1098:12)
at process.internalTickCallback (internal/process/next_tick.js:72:19)

[addaleax]

@leeight Thank you! Can you explain why this fixes the issue, and add a regression test?

[richardlau]

/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:145
if (err) throw err
^
Error: Invalid api format
at new Parser (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/node_modules/gitlint-parser-base/index.js:23:15)
at new Parser (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/node_modules/gitlint-parser-node/index.js:15:5)
at ValidateCommit.lint (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/lib/index.js:49:22)
at load (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:146:9)
at IncomingMessage.res.on (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:77:9)
at IncomingMessage.emit (events.js:187:15)
at endReadableNT (_stream_readable.js:1098:12)
at process.internalTickCallback (internal/process/next_tick.js:72:19)

I think this is a different manifestation of hitting the GitHub API rate limit (#24567) within core-validate-commit rather than before calling it. It should be addressed by #24574 which will avoid calling the GitHub API.

[leeight]

@addaleax OK i'll add a testcase

[addaleax]

I think this has been resolved by #24932? Either way, thank you for the PR! 👍