Uh oh!
There was an error while loading. Please reload this page.
[v11.x backport] doc: sort bottom-of-file markdown links - #24680
Closed
sam-github wants to merge 1 commit into
Closed
[v11.x backport] doc: sort bottom-of-file markdown links#24680sam-github wants to merge 1 commit into
sam-github wants to merge 1 commit into
Conversation
nodejs-github-bot
commented
Nov 27, 2018
Collaborator
@sam-github sadly an error occured when I tried to trigger a build :( |
4 tasks
vsemozhetbyt
commented
Nov 28, 2018
Contributor
Does this need rebasing? |
sam-githubforce-pushed
the
backport-24679-to-v11.x
branch
from
November 28, 2018 17:13
07f1f64 to
69c41f1Comparesam-github
commented
Nov 28, 2018
ContributorAuthor
rebased |
Uh oh!
There was an error while loading. Please reload this page.
vsemozhetbyt
commented
Nov 28, 2018
Contributor
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
sam-github
commented
Nov 29, 2018
ContributorAuthor
sam-githubforce-pushed
the
backport-24679-to-v11.x
branch
from
November 30, 2018 22:30
09f5222 to
b3a9adeComparesam-github
commented
Nov 30, 2018
ContributorAuthor
Trott
approved these changes
Dec 1, 2018
Backport-PR-URL: nodejs#24680 PR-URL: nodejs#24679 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sam-githubforce-pushed
the
backport-24679-to-v11.x
branch
from
December 3, 2018 17:38
b3a9ade to
476272aComparesam-github
commented
Dec 3, 2018
ContributorAuthor
I force pushed with amended description, no other changes. Mostly to get Travis to re-build it. |
sam-github
commented
Dec 3, 2018
ContributorAuthor
BridgeAR
commented
Dec 3, 2018
Member
@sam-github thanks. I am going to prepare a new release tomorrow. |
sam-github
commented
Dec 3, 2018
ContributorAuthor
travis can never find the head commit, AFAICT, it always fails. ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1816/ |
BridgeAR
commented
Dec 5, 2018
Member
Landed in 66d8330 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24679
Preemptive, the sorting doesn't cherrypick well down to release branches, this should help prevent annoying conflicts in the docs.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes