Skip to content

[v10.x backport] doc: sort bottom-of-file markdown links - #24681

Closed
sam-github wants to merge 1 commit into
nodejs:v10.x-stagingfrom
sam-github:backport-24679-to-v10.x
Closed

[v10.x backport] doc: sort bottom-of-file markdown links#24681
sam-github wants to merge 1 commit into
nodejs:v10.x-stagingfrom
sam-github:backport-24679-to-v10.x

Conversation

@sam-github

@sam-githubsam-github commented Nov 27, 2018

Copy link
Copy Markdown
Contributor

Backport of #24679

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Nov 27, 2018

Copy link
Copy Markdown
Collaborator

@sam-github sadly an error occured when I tried to trigger a build :(

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. v10.x labels Nov 27, 2018
This was referenced Nov 27, 2018
Closed
Closed
@vsemozhetbyt

vsemozhetbyt commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

Does this need rebasing?

@sam-github
sam-githubforce-pushed the backport-24679-to-v10.x branch from f7d96c0 to fee088eCompareNovember 28, 2018 17:16
@sam-github

sam-github commented Nov 28, 2018

Copy link
Copy Markdown
ContributorAuthor

This change cherry-picked clean to the head of v10.x-staging, and I repushed.

vsemozhetbyt
vsemozhetbyt reviewed Nov 28, 2018
View reviewed changes
Comment threaddoc/api/deprecations.md Outdated
vsemozhetbyt
vsemozhetbyt approved these changes Nov 28, 2018
View reviewed changes

@vsemozhetbytvsemozhetbyt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a nit.

@vsemozhetbyt

vsemozhetbyt commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@sam-github

sam-github commented Nov 29, 2018

Copy link
Copy Markdown
ContributorAuthor

ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1728/

@sam-github
sam-githubforce-pushed the backport-24679-to-v10.x branch 2 times, most recently from fcaef9b to eb5b537CompareNovember 30, 2018 22:31
@sam-github

sam-github commented Nov 30, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1757

@sam-github
sam-githubforce-pushed the backport-24679-to-v10.x branch from 54f9111 to c3bd8e1CompareDecember 3, 2018 22:02
@sam-github

sam-github commented Dec 3, 2018

Copy link
Copy Markdown
ContributorAuthor

ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1814/

@sam-github
sam-githubforce-pushed the backport-24679-to-v10.x branch from c3bd8e1 to 1f22d97CompareDecember 17, 2018 19:13
MylesBorins pushed a commit that referenced this pull request Dec 21, 2018
@sam-github@MylesBorins
doc: sort bottom-of-file markdown links
a5727ff
Reapply #12726
It would be nice to have the sort check applied as part of doc testing,
but this change doesn't implement that.
Backport-PR-URL: #24681
PR-URL: #24679
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins

MylesBorins commented Dec 21, 2018

Copy link
Copy Markdown
Contributor

landed in a5727ff

MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@sam-github@MylesBorins
doc: sort bottom-of-file markdown links
d2cc9d7
Reapply #12726
It would be nice to have the sort check applied as part of doc testing,
but this change doesn't implement that.
Backport-PR-URL: #24681
PR-URL: #24679
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@sam-github
sam-github deleted the backport-24679-to-v10.x branch November 28, 2019 22:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sam-github@nodejs-github-bot@vsemozhetbyt@MylesBorins