Skip to content

[v10.x backport] doc: correct async_hooks resource names - #24683

Closed
Flarna wants to merge 1 commit into
nodejs:v10.x-stagingfrom
Flarna:v10-async_hooks_doc
Closed

[v10.x backport] doc: correct async_hooks resource names#24683
Flarna wants to merge 1 commit into
nodejs:v10.x-stagingfrom
Flarna:v10-async_hooks_doc

Conversation

@Flarna

@FlarnaFlarna commented Nov 27, 2018

Copy link
Copy Markdown
Member

Correct async hooks resource names to match the implementation:
TCPSERVER => TCPSERVERWRAP

Refs: #17157
Refs: #24001

Checklist

@nodejs-github-botnodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. v10.x labels Nov 27, 2018
@FlarnaFlarna mentioned this pull request Nov 27, 2018
Closed
2 tasks
@Trott

Trott commented Nov 30, 2018

Copy link
Copy Markdown
Member

Needs a rebase or something? Seems to have far too many commits.

@Flarna

Flarna commented Nov 30, 2018

Copy link
Copy Markdown
MemberAuthor

No idea what exactly I did wrong but it should be corrected now.

@Flarna
doc: correct async_hooks resource names
4f44456
Correct async hooks resource names to match the implementation:
`TCPSERVER` => `TCPSERVERWRAP`
Refs: #17157
@Flarna

Flarna commented Dec 12, 2018

Copy link
Copy Markdown
MemberAuthor

Rebased (twice)

MylesBorins pushed a commit that referenced this pull request Dec 21, 2018
@Flarna@MylesBorins
doc: correct async_hooks resource names
57ccaf6
Correct async hooks resource names to match the implementation:
`TCPSERVER` => `TCPSERVERWRAP`
Backport-PR-URL: #24683
PR-URL: #24001
Refs: #21971
Refs: #17157
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins

MylesBorins commented Dec 21, 2018

Copy link
Copy Markdown
Contributor

landed in 57ccaf6

@Flarna
Flarna deleted the v10-async_hooks_doc branch December 21, 2018 17:25
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@Flarna@MylesBorins
doc: correct async_hooks resource names
4209e12
Correct async hooks resource names to match the implementation:
`TCPSERVER` => `TCPSERVERWRAP`
Backport-PR-URL: #24683
PR-URL: #24001
Refs: #21971
Refs: #17157
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

async_hooksIssues and PRs related to the async hooks subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Flarna@Trott@MylesBorins@nodejs-github-bot