Skip to content

[v8.x backport] doc: correct async_hooks resource names - #24684

Closed
Flarna wants to merge 1 commit into
nodejs:v8.x-stagingfrom
Flarna:v8-async_hooks_doc
Closed

[v8.x backport] doc: correct async_hooks resource names#24684
Flarna wants to merge 1 commit into
nodejs:v8.x-stagingfrom
Flarna:v8-async_hooks_doc

Conversation

@Flarna

Copy link
Copy Markdown
Member

Correct async hooks resource names to match the implementation:
TCPSERVER => TCPSERVERWRAP

Refs: #17157
Refs: #24001

Checklist

@nodejs-github-botnodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. v8.x labels Nov 27, 2018
@FlarnaFlarna mentioned this pull request Nov 27, 2018
2 tasks
@Trott

Trott commented Nov 30, 2018

Copy link
Copy Markdown
Member

Needs a rebase or something? Seems to have far too many commits.

Correct async hooks resource names to match the implementation:
`TCPSERVER` => `TCPSERVERWRAP`
Refs: #17157
@Flarna

Copy link
Copy Markdown
MemberAuthor

No idea what exactly I did wrong but it should be corrected now.

BethGriggs pushed a commit that referenced this pull request Dec 3, 2018
Correct async hooks resource names to match the implementation:
`TCPSERVER` => `TCPSERVERWRAP`
Refs: #17157
PR-URL: #24684
Refs: #17157
Refs: #24001
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs

Copy link
Copy Markdown
Member

Landed in f5683a9

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async_hooksIssues and PRs related to the async hooks subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Flarna@Trott@BethGriggs@nodejs-github-bot