Skip to content

doc: describe current HTTP header size limit - #24700

Closed
sam-github wants to merge 2 commits into
nodejs:masterfrom
sam-github:doc-8kb-http-header-limit
Closed

doc: describe current HTTP header size limit#24700
sam-github wants to merge 2 commits into
nodejs:masterfrom
sam-github:doc-8kb-http-header-limit

Conversation

@sam-github

@sam-githubsam-github commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Nov 28, 2018

Copy link
Copy Markdown
Collaborator

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1708/pipeline

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Nov 28, 2018
@sam-github

sam-github commented Nov 28, 2018

Copy link
Copy Markdown
ContributorAuthor

This does not replace #24693, it fixes the existing reference to 80KB in errors.md, but doesn't touch the HTTP docs themselves. It was intended that this be part of 1860352 but it got missed, sorry.

mcollina
mcollina approved these changes Nov 28, 2018
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sam-github
doc: describe current HTTP header size limit
19cdee8
Document that the limit was changed from 80KB to 8KB in 1860352.
Fixes: nodejs#24693
@sam-github
sam-githubforce-pushed the doc-8kb-http-header-limit branch from bfb4d4a to 19cdee8CompareNovember 28, 2018 18:12
vsemozhetbyt
vsemozhetbyt reviewed Nov 28, 2018
View reviewed changes
Comment threaddoc/api/errors.md Outdated
@vsemozhetbytvsemozhetbyt added http Issues or PRs related to the http subsystem. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. labels Nov 28, 2018
@vsemozhetbyt@sam-github
fixup
bb3d672
Co-Authored-By: sam-github <vieuxtech@gmail.com>
@sam-github

sam-github commented Nov 28, 2018

Copy link
Copy Markdown
ContributorAuthor

sorry, misunderstood format of description field

@vsemozhetbyt

vsemozhetbyt commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt

vsemozhetbyt commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1711/

@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2018
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 28, 2018
@Trott

Trott commented Nov 28, 2018

Copy link
Copy Markdown
Member

Landed in 063e8fb

@TrottTrott closed this Nov 28, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 28, 2018
@sam-github@Trott
doc: describe current HTTP header size limit
063e8fb
Document that the limit was changed from 80KB to 8KB in 1860352.
Fixes: nodejs#24693
PR-URL: nodejs#24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@sam-github
sam-github deleted the doc-8kb-http-header-limit branch November 28, 2018 21:59
targos pushed a commit that referenced this pull request Nov 29, 2018
@sam-github@targos
doc: describe current HTTP header size limit
68dc100
Document that the limit was changed from 80KB to 8KB in 1860352.
Fixes: #24693
PR-URL: #24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@sam-github@MylesBorins
doc: describe current HTTP header size limit
f30d169
Document that the limit was changed from 80KB to 8KB in 1860352.
Fixes: #24693
PR-URL: #24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@sam-github@MylesBorins
doc: describe current HTTP header size limit
e669733
Document that the limit was changed from 80KB to 8KB in 1860352.
Fixes: #24693
PR-URL: #24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Dec 25, 2018
Merged
This was referenced Dec 26, 2018
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@sam-github@refack
doc: describe current HTTP header size limit
f045f1b
Document that the limit was changed from 80KB to 8KB in 1860352.
Fixes: nodejs#24693
PR-URL: nodejs#24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
+1 more reviewer
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.errorsIssues and PRs related to JavaScript errors originated in Node.js core.fast-trackPRs that do not need to wait for 48 hours to land.http_parserIssues and PRs related to the HTTP Parser dependency or the http_parser binding.httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing API docs for recent changes in HTTP module

6 participants

@sam-github@nodejs-github-bot@vsemozhetbyt@Trott@mcollina@MylesBorins