Uh oh!
There was an error while loading. Please reload this page.
src: remove unused variables node_util.cc - #24717
Closed
danbev wants to merge 1 commit into
Closed
Conversation
Currently the following warnings are generated: ../src/node_util.cc:59:16: warning: unused variable 'env' [-Wunused-variable] Environment* env = Environment::GetCurrent(args); ^ ../src/node_util.cc:78:16: warning: unused variable 'env' [-Wunused-variable] Environment* env = Environment::GetCurrent(args); ^ 2 warnings generated. This commit removes these unused variables.
richardlau
approved these changes
Nov 29, 2018
joyeecheung
approved these changes
Nov 29, 2018
Trott
commented
Nov 29, 2018
Member
Resume Build CI https://ci.nodejs.org/job/node-test-pull-request/19048/ |
cjihrig
approved these changes
Nov 29, 2018
maclover7
approved these changes
Nov 29, 2018
Trott
commented
Nov 29, 2018
Member
Collaborators, 👍 to fast-track. |
lpinca
approved these changes
Nov 29, 2018
lpinca
commented
Nov 29, 2018
Member
I think there is a typo in commit title (missing "in"). |
Trott
commented
Nov 30, 2018
Member
Landed in 171b810 |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 30, 2018
Currently two warnings are generated regarding unused variables. This commit removes the unused variables. PR-URL: nodejs#24717 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Dec 5, 2018
Currently two warnings are generated regarding unused variables. This commit removes the unused variables. PR-URL: #24717 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Dec 7, 2018
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Currently two warnings are generated regarding unused variables. This commit removes the unused variables. PR-URL: nodejs#24717 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the following warnings are generated:
This commit removes these unused variables.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes