Skip to content

deps: upgrade npm to 6.5.0 - #24734

Closed
aeschright wants to merge 1 commit into
nodejs:masterfrom
npm:npm-6.5.0
Closed

deps: upgrade npm to 6.5.0#24734
aeschright wants to merge 1 commit into
nodejs:masterfrom
npm:npm-6.5.0

Conversation

@aeschright

@aeschrightaeschright commented Nov 29, 2018•
edited
Loading

Copy link
Copy Markdown
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Where this should land
  • Node 10
  • Node 8
Notable Changes

This is a pre-release of npm@6.5.0 including a number of bugfixes and documentation updates.

Another reminder that we've moved our issue tracking! You can read more about our move away from GitHub for issue tracking on our blog.

Changelogs

@nodejs-github-botnodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Nov 29, 2018
@zkat

zkat commented Nov 30, 2018

Copy link
Copy Markdown
Contributor

Oh right, node@11 is out now too. Should we add it to the list?

@targos

targos commented Nov 30, 2018

Copy link
Copy Markdown
Member

@zkat Do you mean the "Where this should land" list?
SGTM. It's not strictly necessary because we try to backport everything to Node 11 unless the PR is explicitly labeled dont-land-on-v11.x

@richardlaurichardlau added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 30, 2018
@Trott

Trott commented Dec 2, 2018

Copy link
Copy Markdown
Member

This needs some reviews, although I imagine they'll be largely of the rubber-stamp variety... @nodejs/npm

@Trott

Trott commented Dec 2, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19128/

addaleax
addaleax approved these changes Dec 4, 2018
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@addaleax

addaleax commented Dec 4, 2018

Copy link
Copy Markdown
Member

Only failure is a known flake … Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19187/

@targostargos added the blocked PRs that are blocked by other issues or PRs. label Dec 4, 2018
@targos

targos commented Dec 4, 2018

Copy link
Copy Markdown
Member

Blocking until npm 6.5.0has been latest for two weeks.

@Trott

Trott commented Dec 4, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Resume Build CI again: https://ci.nodejs.org/job/node-test-pull-request/19197/ ✔️

@joyeecheungjoyeecheung mentioned this pull request Dec 5, 2018
Closed
@MylesBorins

MylesBorins commented Dec 11, 2018

Copy link
Copy Markdown
Contributor

6.5.0 has been promoted to latest... as such we can land this on December 25th... A holiday present!

@bricssbricss mentioned this pull request Dec 18, 2018
Merged
@MylesBorins

MylesBorins commented Dec 25, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Other CI results are stale: https://ci.nodejs.org/job/node-test-pull-request/19793/

edit:

Two flakes on AIX, re-running: https://ci.nodejs.org/job/node-test-commit-aix/20022/

@MylesBorinsMylesBorins removed the blocked PRs that are blocked by other issues or PRs. label Dec 25, 2018
@MylesBorins

MylesBorins commented Dec 25, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

rebased against master, one more CI https://ci.nodejs.org/job/node-test-pull-request/19798/

MylesBorins
MylesBorins approved these changes Dec 25, 2018
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins

MylesBorins commented Dec 25, 2018

Copy link
Copy Markdown
Contributor

landed in 13ae538

MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
Audrey Eschright@MylesBorins
deps: upgrade npm to 6.5.0
585e014
PR-URL: #24734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
pullBot pushed a commit to SimenB/node that referenced this pull request Dec 25, 2018
Audrey Eschright@MylesBorins
deps: upgrade npm to 6.5.0
13ae538
PR-URL: nodejs#24734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 25, 2018
@MylesBorins
2018-12-26, Version 11.6.0 (Current)
f59e73b
Notable Changes:
* cli:
- add --max-http-header-size flag (cjihrig)
#24811
* crypto:
- always accept certificates as public keys (Tobias Nießen)
#24234
- add key object API (Tobias Nießen) [#24234](#24234)
- update root certificates (Sam Roberts)
#25113
* deps:
- upgrade to libuv 1.24.1 (cjihrig)
#25078
- upgrade npm to 6.5.0 (Audrey Eschright)
#24734
* http:
- add maxHeaderSize property (cjihrig)
#24860
PR-URL: #25175
@MylesBorinsMylesBorins mentioned this pull request Dec 25, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
Audrey Eschright@MylesBorins
deps: upgrade npm to 6.5.0
e855018
PR-URL: #24734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 26, 2018
@MylesBorins
2018-12-26, Version 11.6.0 (Current)
fb9130f
Notable Changes:
* cli:
- add --max-http-header-size flag (cjihrig)
#24811
* crypto:
- always accept certificates as public keys (Tobias Nießen)
#24234
- add key object API (Tobias Nießen) [#24234](#24234)
- update root certificates (Sam Roberts)
#25113
* deps:
- upgrade to libuv 1.24.1 (cjihrig)
#25078
- upgrade npm to 6.5.0 (Audrey Eschright)
#24734
* http:
- add maxHeaderSize property (cjihrig)
#24860
PR-URL: #25175
MylesBorins added a commit that referenced this pull request Dec 26, 2018
@MylesBorins
2018-12-26, Version 11.6.0 (Current)
968e901
Notable Changes:
* cli:
- add --max-http-header-size flag (cjihrig)
#24811
* crypto:
- always accept certificates as public keys (Tobias Nießen)
#24234
- add key object API (Tobias Nießen) [#24234](#24234)
- update root certificates (Sam Roberts)
#25113
* deps:
- upgrade to libuv 1.24.1 (cjihrig)
#25078
- upgrade npm to 6.5.0 (Audrey Eschright)
#24734
* http:
- add maxHeaderSize property (cjihrig)
#24860
PR-URL: #25175
MylesBorins added a commit that referenced this pull request Dec 26, 2018
@MylesBorins
2018-12-26, Version 11.6.0 (Current)
e01999d
Notable Changes:
* cli:
- add --max-http-header-size flag (cjihrig)
#24811
* crypto:
- always accept certificates as public keys (Tobias Nießen)
#24234
- add key object API (Tobias Nießen) [#24234](#24234)
- update root certificates (Sam Roberts)
#25113
* deps:
- upgrade to libuv 1.24.1 (cjihrig)
#25078
- upgrade npm to 6.5.0 (Audrey Eschright)
#24734
* http:
- add maxHeaderSize property (cjihrig)
#24860
PR-URL: #25175
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Audrey Eschright@refack
deps: upgrade npm to 6.5.0
1f63a27
PR-URL: nodejs#24734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@MylesBorins@refack
2018-12-26, Version 11.6.0 (Current)
c842f7b
Notable Changes:
* cli:
- add --max-http-header-size flag (cjihrig)
nodejs#24811
* crypto:
- always accept certificates as public keys (Tobias Nießen)
nodejs#24234
- add key object API (Tobias Nießen) [nodejs#24234](nodejs#24234)
- update root certificates (Sam Roberts)
nodejs#25113
* deps:
- upgrade to libuv 1.24.1 (cjihrig)
nodejs#25078
- upgrade npm to 6.5.0 (Audrey Eschright)
nodejs#24734
* http:
- add maxHeaderSize property (cjihrig)
nodejs#24860
PR-URL: nodejs#25175
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
Audrey Eschright@BethGriggs
deps: upgrade npm to 6.5.0
04591e9
PR-URL: #24734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
Audrey Eschright@BethGriggs
deps: upgrade npm to 6.5.0
f9c4a19
PR-URL: #24734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
Audrey Eschright@BethGriggs
deps: upgrade npm to 6.5.0
0933bcf
PR-URL: #24734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
Audrey Eschright@MylesBorins
deps: upgrade npm to 6.5.0
391185e
PR-URL: #24734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@wraithgar
wraithgar deleted the npm-6.5.0 branch June 26, 2025 15:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@watildewatildewatilde approved these changes
+1 more reviewer
@MylesBorinsMylesBorinsMylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

npmIssues and PRs related to the npm client dependency or the npm registry.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@aeschright@zkat@targos@Trott@addaleax@MylesBorins@watilde@richardlau@nodejs-github-bot