Skip to content

doc: add class: worker documentation - #24809

Closed
yoshimoto8 wants to merge 8 commits into
nodejs:masterfrom
yoshimoto8:add-doc-worker
Closed

doc: add class: worker documentation#24809
yoshimoto8 wants to merge 8 commits into
nodejs:masterfrom
yoshimoto8:add-doc-worker

Conversation

@yoshimoto8

@yoshimoto8yoshimoto8 commented Dec 3, 2018

Copy link
Copy Markdown
Contributor

Add documentation about Worker class inherits from EventEmitter.

related #24732

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows [commit guidelines]

@yoshimoto8
doc: Add Class: Worker documentation
987e484
Add documentation about Worker class inherits from EventEmitter.
@yoshimoto8
modify: indent fix
fdb3e23
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 3, 2018
@yoshimoto8yoshimoto8 changed the title Add doc workerdoc: Add Class: Worker documentationDec 3, 2018
vsemozhetbyt
vsemozhetbyt reviewed Dec 3, 2018
View reviewed changes
Comment threaddoc/api/worker_threads.md Outdated
@vsemozhetbyt

vsemozhetbyt commented Dec 3, 2018

Copy link
Copy Markdown
Contributor

cc @nodejs/workers

@vsemozhetbytvsemozhetbyt added the worker Issues and PRs related to Worker support. label Dec 3, 2018
@lpinca

lpinca commented Dec 3, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Can we use extends instead like it's done for MessagePort? See https://github.com/nodejs/node/blob/2e03b76bcf9e8d84862942a557a09af47d105d5f/doc/api/worker_threads.md#class-messageport

@yoshimoto8yoshimoto8 changed the title doc: Add Class: Worker documentationdoc: add class: worker documentationDec 5, 2018
@yoshimoto8
fixes: fixed pointed out
c8092fd
Since ci failed, it is recommitted and fixed indent num and english grammar.
@yoshimoto8
doc: add class: worker documentation
cf835d1
Add documentation about worker class inherits from eventEmitter.
@yoshimoto8
modify: indent fix
b57fddb
@yoshimoto8
fixes: fixed pointed out
527b0e2
Since ci failed, it is recommitted and fixed indent num and english grammar.
@yoshimoto8
Merge branch 'master' ofhttps://github.com/nodejs/nodeinto add-doc-…
9ac5abe
…worker
@yoshimoto8
Merge branch 'add-doc-worker' of github.com:yoshimoto8/node into add-…
e42716b
…doc-worker
@yoshimoto8yoshimoto8 mentioned this pull request Dec 5, 2018
Closed
3 tasks
@lpinca

lpinca commented Dec 11, 2018

Copy link
Copy Markdown
Member

Superseded by #24849

@lpincalpinca closed this Dec 11, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@vsemozhetbytvsemozhetbytvsemozhetbyt left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yoshimoto8@vsemozhetbyt@lpinca@nodejs-github-bot